Conversation
IncludeDescendants on ContentPublishedNotification when publishing branchIncludeDescendants on ContentPublishedNotification when publishing branch
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where the IncludeDescendants property on ContentPublishedNotification was not being populated when publishing a content branch. The fix ensures that the notification correctly indicates when descendants are being published as part of a branch publish operation.
Key Changes:
- Updated the
ContentPublishedNotificationconstructor call inSaveAndPublishBranchto passtruefor theIncludeDescendantsparameter
Migaroez
approved these changes
Oct 22, 2025
Contributor
Migaroez
left a comment
There was a problem hiding this comment.
Can't think of any sideffects. Good to go 👍
AndyButland
added a commit
that referenced
this pull request
Oct 22, 2025
…ishing branch (forward port of #20578).
AndyButland
added a commit
that referenced
this pull request
Oct 22, 2025
…ishing branch (forward port of #20578).
This was referenced Dec 9, 2025
This was referenced Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Resolves: #20575
Description
This looks a fairly straightforward oversight and fix - we have
IncludeDescendantsonContentPublishedNotificationbut aren't currently populating it when publishing a branch as the wrong constructor is being called.Testing
Can use the following notification handler and composer for testing.