Localization: Fixed message in block group delete confirm modal (closes #20308)#20312
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a localization issue in the block grid editor where the confirm message for deleting a block group was not being displayed correctly. The issue was caused by an incorrect localization key format.
- Fixed the localization key from using hash prefix to proper key format
|
Hi there @bjarnef, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
There was a problem hiding this comment.
Looks good to me @bjarnef and works as expected.
Do you think you could just look at the translation message though that currently says "Are you sure you want to delete group Test and all the Block configurations of this?" please?
Looking at the actual behaviour I think it can just say "Are you sure you want to delete group Test?" Partly as "of this" is a bit of a clunky phrase, but mostly I notice that actually the block configurations aren't deleted, they are moved into the non-grouped configurations.
|
@AndyButland agree, I have updated the translation as the part "and all the Block configurations of this" isn't relevant, as blocks under the deleted group are moved to "Unnamed" group. |
AndyButland
left a comment
There was a problem hiding this comment.
Thanks @bjarnef, approving now.
Prerequisites
If there's an existing issue for this PR then this fixes #20308
Description
Fixed localization of confirm message, when deleting block group.
I also added translation of block type removal.
And a few "block" translations in Danish. Furthermore many words in English is a single word in Danish (although it may be a long word, not always align nicely). I fixed a few of these.