Skip to content

Localization: Fixed message in block group delete confirm modal (closes #20308)#20312

Merged
AndyButland merged 5 commits intoumbraco:mainfrom
bjarnef:bugfix/20308-delete-block-group-message
Sep 30, 2025
Merged

Localization: Fixed message in block group delete confirm modal (closes #20308)#20312
AndyButland merged 5 commits intoumbraco:mainfrom
bjarnef:bugfix/20308-delete-block-group-message

Conversation

@bjarnef
Copy link
Contributor

@bjarnef bjarnef commented Sep 29, 2025

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes #20308

Description

Fixed localization of confirm message, when deleting block group.

image

I also added translation of block type removal.

image

And a few "block" translations in Danish. Furthermore many words in English is a single word in Danish (although it may be a long word, not always align nicely). I fixed a few of these.

Copilot AI review requested due to automatic review settings September 29, 2025 23:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a localization issue in the block grid editor where the confirm message for deleting a block group was not being displayed correctly. The issue was caused by an incorrect localization key format.

  • Fixed the localization key from using hash prefix to proper key format

@github-actions
Copy link

Hi there @bjarnef, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

Copy link
Contributor

@AndyButland AndyButland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @bjarnef and works as expected.

Do you think you could just look at the translation message though that currently says "Are you sure you want to delete group Test and all the Block configurations of this?" please?

Looking at the actual behaviour I think it can just say "Are you sure you want to delete group Test?" Partly as "of this" is a bit of a clunky phrase, but mostly I notice that actually the block configurations aren't deleted, they are moved into the non-grouped configurations.

@bjarnef
Copy link
Contributor Author

bjarnef commented Sep 30, 2025

@AndyButland agree, I have updated the translation as the part "and all the Block configurations of this" isn't relevant, as blocks under the deleted group are moved to "Unnamed" group.

Copy link
Contributor

@AndyButland AndyButland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bjarnef, approving now.

@AndyButland AndyButland enabled auto-merge (squash) September 30, 2025 06:57
@AndyButland AndyButland changed the title Fix localized message in block group delete confirm modal Localization: Fixed message in block group delete confirm modal (closes #20308) Sep 30, 2025
@AndyButland AndyButland merged commit 1082bf1 into umbraco:main Sep 30, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove block group doesn't show group name in modal

2 participants