E2E nightly pipeline: QA Fix failing acceptance tests for invalid cases

tests/Umbraco.Tests.AcceptanceTest/package.json

@@ -22,7 +22,7 @@
   },
   "dependencies": {
     "@umbraco/json-models-builders": "^2.0.40",
-    "@umbraco/playwright-testhelpers": "^16.0.47",
+    "@umbraco/playwright-testhelpers": "^16.0.48",
     "camelize": "^1.0.0",
     "dotenv": "^16.3.1",
     "node-fetch": "^2.6.7"

tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithCheckboxList.spec.ts

@@ -93,11 +93,11 @@ test('can not publish a mandatory checkbox list with an empty value', {tag: '@re
   await umbracoUi.content.goToContentWithName(contentName);
   // Do not select any checkbox list values and the validation error appears
   await umbracoUi.content.clickSaveAndPublishButton();
-  await umbracoUi.content.isValidationMessageVisible(ConstantHelper.validationMessages.emptyValue);
+  await umbracoUi.content.isValidationMessageVisible(ConstantHelper.validationMessages.nullValue);
   await umbracoUi.content.doesErrorNotificationHaveText(NotificationConstantHelper.error.documentCouldNotBePublished);
   // Select a checkbox list value and the validation error disappears
   await umbracoUi.content.chooseCheckboxListOption(optionValues[0]);
-  await umbracoUi.content.isValidationMessageVisible(ConstantHelper.validationMessages.emptyValue, false);
+  await umbracoUi.content.isValidationMessageVisible(ConstantHelper.validationMessages.nullValue, false);
   await umbracoUi.content.clickSaveAndPublishButton();
 
   // Assert

tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithDropdown.spec.ts

@@ -96,11 +96,11 @@ test('can not publish a mandatory dropdown with an empty value', {tag: '@release
   await umbracoUi.content.goToContentWithName(contentName);
   // Do not select any dropdown values and the validation error appears
   await umbracoUi.content.clickSaveAndPublishButton();
-  await umbracoUi.content.isValidationMessageVisible(ConstantHelper.validationMessages.emptyValue);
+  await umbracoUi.content.isValidationMessageVisible(ConstantHelper.validationMessages.nullValue);
   await umbracoUi.content.doesErrorNotificationHaveText(NotificationConstantHelper.error.documentCouldNotBePublished);
   // Select a dropdown value and the validation error disappears
   await umbracoUi.content.chooseDropdownOption([optionValues[0]]);
-  await umbracoUi.content.isValidationMessageVisible(ConstantHelper.validationMessages.emptyValue, false);
+  await umbracoUi.content.isValidationMessageVisible(ConstantHelper.validationMessages.nullValue, false);
   await umbracoUi.content.clickSaveAndPublishButton();
 
   // Assert

tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithRadiobox.spec.ts

@@ -96,11 +96,11 @@ test('can not publish mandatory radiobox with an empty value', {tag: '@release'}
   await umbracoUi.content.goToContentWithName(contentName);
   // Do not select any radiobox values and the validation error appears
   await umbracoUi.content.clickSaveAndPublishButton();
-  await umbracoUi.content.isValidationMessageVisible(ConstantHelper.validationMessages.emptyValue);
+  await umbracoUi.content.isValidationMessageVisible(ConstantHelper.validationMessages.nullValue);
   await umbracoUi.content.doesErrorNotificationHaveText(NotificationConstantHelper.error.documentCouldNotBePublished);
   // Select a radiobox value and the validation error disappears
   await umbracoUi.content.chooseRadioboxOption(optionValues[0]);
-  await umbracoUi.content.isValidationMessageVisible(ConstantHelper.validationMessages.emptyValue, false);
+  await umbracoUi.content.isValidationMessageVisible(ConstantHelper.validationMessages.nullValue, false);
   await umbracoUi.content.clickSaveAndPublishButton();
 
   // Assert

tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/BlockGrid/Block/BlockGridBlockAdvanced.spec.ts

@@ -240,9 +240,7 @@ test('can remove a icon color from a block', async ({umbracoApi, umbracoUi}) =>
   expect(await umbracoApi.dataType.doesBlockEditorBlockContainIconColor(blockGridEditorName, contentElementTypeId, '')).toBeTruthy();
 });
 
-// Remove skip when the front-end is ready. Currently it is not possible to add a thumbnail to a block
-// Issue link: https://github.com/umbraco/Umbraco-CMS/issues/20264
-test.skip('can add a thumbnail to a block', {tag: '@smoke'}, async ({umbracoApi, umbracoUi}) => {
+test('can add a thumbnail to a block', {tag: '@smoke'}, async ({umbracoApi, umbracoUi}) => {
   // Arrange
   const mediaName = 'TestMedia';
   await umbracoApi.media.ensureNameNotExists(mediaName);

tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/RichTextEditor.spec.ts

@@ -8,6 +8,7 @@ const tipTapUiAlias = 'Umb.PropertyEditorUi.Tiptap';
 const extensionsDefaultValue = [
   "Umb.Tiptap.RichTextEssentials",
   "Umb.Tiptap.Anchor",
+  "Umb.Tiptap.Block",
   "Umb.Tiptap.Blockquote",
   "Umb.Tiptap.Bold",
   "Umb.Tiptap.BulletList",
@@ -35,8 +36,7 @@ const extensionsDefaultValue = [
   "Umb.Tiptap.TextDirection",
   "Umb.Tiptap.TextIndent",
   "Umb.Tiptap.TrailingNode",
-  "Umb.Tiptap.Underline",
-  "Umb.Tiptap.WordCount"
+  "Umb.Tiptap.Underline"
 ];
 
 const toolbarDefaultValue = [

tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Media/Media.spec.ts

@@ -25,7 +25,8 @@ test('can not create a empty media file', {tag: '@release'}, async ({umbracoApi,
   await umbracoUi.media.clickSaveButton();
 
   // Assert
-  await umbracoUi.media.isErrorNotificationVisible();
+  await umbracoUi.media.isFailedStateButtonVisible();
+  await umbracoUi.media.isValidationMessageVisible(ConstantHelper.validationMessages.nullValue);
   await umbracoUi.media.isMediaTreeItemVisible(mediaFileName, false);
   expect(await umbracoApi.media.doesNameExist(mediaFileName)).toBeFalsy();
 });

tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Members/Members.spec.ts

@@ -1,4 +1,4 @@
-import {NotificationConstantHelper, test} from '@umbraco/playwright-testhelpers';
+import {ConstantHelper, NotificationConstantHelper, test} from '@umbraco/playwright-testhelpers';
 import {expect} from "@playwright/test";
 
 let memberId = '';
@@ -241,7 +241,7 @@ test('cannot create member with invalid email', {tag: '@release'}, async ({umbra
 
   // Assert
   await umbracoUi.member.isFailedStateButtonVisible();
-  await umbracoUi.member.doesErrorNotificationHaveText(NotificationConstantHelper.error.invalidEmail);
+  await umbracoUi.member.isValidationMessageVisible(ConstantHelper.validationMessages.invalidEmail);
   expect(await umbracoApi.member.doesNameExist(memberName)).toBeFalsy();
 });
 
@@ -259,7 +259,7 @@ test('cannot update email to an invalid email', async ({umbracoApi, umbracoUi})
 
   // Assert
   await umbracoUi.member.isFailedStateButtonVisible();
-  await umbracoUi.member.isErrorNotificationVisible();
+  await umbracoUi.member.isValidationMessageVisible(ConstantHelper.validationMessages.invalidEmail);
   const memberData = await umbracoApi.member.get(memberId);
   expect(memberData.email).toBe(email);
 });