Skip to content

Installer: Improves user accessibility by adding missing <form> elements and setting the right focus#20265

Merged
leekelleher merged 2 commits into
release/16.3from
v16/bugfix/installer-form-improvements
Sep 25, 2025
Merged

Installer: Improves user accessibility by adding missing <form> elements and setting the right focus#20265
leekelleher merged 2 commits into
release/16.3from
v16/bugfix/installer-form-improvements

fix: adds umbFocus to select inputs to allow the user to proceed with…

a099287
Select commit
Loading
Failed to load commit list.
Azure Pipelines / Umbraco CMS 9+ succeeded Sep 25, 2025 in 35m 12s

Build #16.3.0--rc.preview.170+529e72d had test failures

Details

Tests

  • Failed: 1 (0.01%)
  • Passed: 16,473 (99.58%)
  • Other: 68 (0.41%)
  • Total: 16,542

Annotations

Check failure on line 258 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Umbraco CMS 9+

Build log #L258

PowerShell exited with code '1'.

Check failure on line 1 in can add a thumbnail to a block

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Umbraco CMS 9+

can add a thumbnail to a block

BlockGridBlockAdvanced.spec.ts:243:5 can add a thumbnail to a block
Raw output
  [defaultConfig] › DefaultConfig\DataType\BlockGrid\Block\BlockGridBlockAdvanced.spec.ts:243:5 › can add a thumbnail to a block @smoke 

    Test timeout of 30000ms exceeded.

    Error: locator.getAttribute: Test timeout of 30000ms exceeded.
    Call log:
      - waiting for locator('uui-menu-item[label="wwwroot"]')


      255 |   await umbracoUi.dataType.goToBlockWithName(elementTypeName);
      256 |   await umbracoUi.dataType.goToBlockAdvancedTab();
    > 257 |   await umbracoUi.dataType.chooseBlockThumbnailWithPath(mediaUrl);
          |   ^
      258 |   await umbracoUi.dataType.clickSubmitButton();
      259 |   await umbracoUi.dataType.clickSaveButton();
      260 |
        at DataTypeUiHelper.openCaretButtonForName (D:\a\1\s\tests\Umbraco.Tests.AcceptanceTest\node_modules\@umbraco\playwright-testhelpers\lib\helpers\UiBaseLocators.ts:335:46)
        at DataTypeUiHelper.chooseBlockThumbnailWithPath (D:\a\1\s\tests\Umbraco.Tests.AcceptanceTest\node_modules\@umbraco\playwright-testhelpers\lib\helpers\DataTypeUiHelper.ts:1008:16)
        at D:\a\1\s\tests\Umbraco.Tests.AcceptanceTest\tests\DefaultConfig\DataType\BlockGrid\Block\BlockGridBlockAdvanced.spec.ts:257:3

    attachment #1: trace (application/zip) ─────────────────────────────────────────────────────────
    results\DefaultConfig-DataType-Blo-db342--add-a-thumbnail-to-a-block-defaultConfig\trace.zip
    Usage:

        npx playwright show-trace results\DefaultConfig-DataType-Blo-db342--add-a-thumbnail-to-a-block-defaultConfig\trace.zip

    ────────────────────────────────────────────────────────────────────────────────────────────────

    Retry #1 ───────────────────────────────────────────────────────────────────────────────────────

    Test timeout of 30000ms exceeded.

    Error: locator.getAttribute: Test timeout of 30000ms exceeded.
    Call log:
      - waiting for locator('uui-menu-item[label="wwwroot"]')


      255 |   await umbracoUi.dataType.goToBlockWithName(elementTypeName);
      256 |   await umbracoUi.dataType.goToBlockAdvancedTab();
    > 257 |   await umbracoUi.dataType.chooseBlockThumbnailWithPath(mediaUrl);
          |   ^
      258 |   await umbracoUi.dataType.clickSubmitButton();
      259 |   await umbracoUi.dataType.clickSaveButton();
      260 |
        at DataTypeUiHelper.openCaretButtonForName (D:\a\1\s\tests\Umbraco.Tests.AcceptanceTest\node_modules\@umbraco\playwright-testhelpers\lib\helpers\UiBaseLocators.ts:335:46)
        at DataTypeUiHelper.chooseBlockThumbnailWithPath (D:\a\1\s\tests\Umbraco.Tests.AcceptanceTest\node_modules\@umbraco\playwright-testhelpers\lib\helpers\DataTypeUiHelper.ts:1008:16)
        at D:\a\1\s\tests\Umbraco.Tests.AcceptanceTest\tests\DefaultConfig\DataType\BlockGrid\Block\BlockGridBlockAdvanced.spec.ts:257:3

    attachment #1: trace (application/zip) ─────────────────────────────────────────────────────────
    results\DefaultConfig-DataType-Blo-db342--add-a-thumbnail-to-a-block-defaultConfig-retry1\trace.zip
    Usage:

        npx playwright show-trace results\DefaultConfig-DataType-Blo-db342--add-a-thumbnail-to-a-block-defaultConfig-retry1\trace.zip

    ────────────────────────────────────────────────────────────────────────────────────────────────

    Retry #2 ───────────────────────────────────────────────────────────────────────────────────────

    Test timeout of 30000ms exceeded.

    Error: locator.getAttribute: Test timeout of 30000ms exceeded.
    Call log:
      - waiting for locator('uui-menu-item[label="wwwroot"]')


      255 |   await umbracoUi.dataType.goToBlockWithName(elementTypeName);
      256 |   await umbracoUi.dataType.goToBlockAdvancedTab();
    > 257 |   await umbracoUi.dataType.chooseBlockThumbnailWithPath(mediaUrl);
          |   ^
      258 |   await umbracoUi.dataType.clickSubmitButton();
      259 |   await umbracoUi.dataType.clickSaveButton();
      260 |
        at DataTypeUiHelper.openCaretButtonForName (D:\a\1\s\tests\Umbraco.Tests.AcceptanceTest\node_modules\@umb