Login form: Improves accessibility by removing duplicate label and aria-label#20232
Merged
iOvergaard merged 1 commit intomainfrom Oct 2, 2025
Merged
Login form: Improves accessibility by removing duplicate label and aria-label#20232iOvergaard merged 1 commit intomainfrom
iOvergaard merged 1 commit intomainfrom
Conversation
…eady have <label> tag
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves accessibility by removing redundant aria-label attributes from username and password input fields that already have proper label elements associated with them. The change eliminates unnecessary localization calls and simplifies the input creation process.
Key Changes
- Removed
labelparameter fromcreateInputfunction interface - Eliminated
ariaLabelassignment in input creation - Removed unused
labelUsernameandlabelPasswordlocal variables
iOvergaard
approved these changes
Oct 2, 2025
iOvergaard
changed the title
iOvergaard
changed the title
This was referenced Jan 26, 2026
This was referenced Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed Aria label from the username and password input, since we already have a label attached to each of these input elements.
Since the aria label was not needed labelUsername and labelPassword were also removed