Skip to content

Variants: Implements validation hints to the variant selector (closes #19953) - #20179

Merged
leekelleher merged 8 commits into
mainfrom
v16/feature/variant-hints
Sep 18, 2025
Merged

Variants: Implements validation hints to the variant selector (closes #19953)#20179
leekelleher merged 8 commits into
mainfrom
v16/feature/variant-hints

only add a new hint if the weight is higher

73712ba
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Sep 18, 2025 in 40s

CodeScene PR Check

Quality Gate Failed

Gates Failed
Enforce advisory code health rules (1 file with Complex Method)

Gates Passed
3 Quality Gates Passed

See analysis details in CodeScene

Reason for failure
Enforce advisory code health rules Violations Code Health Impact
workspace-split-view-variant-selector.element.ts 1 advisory rule 9.39 → 8.90 Suppress

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method workspace-split-view-variant-selector.element.ts: UmbWorkspaceSplitViewVariantSelectorElement.render
  • Complex Method workspace-split-view-variant-selector.element.ts: UmbWorkspaceSplitViewVariantSelectorElement.constructor

Annotations

Check warning on line 372 in src/Umbraco.Web.UI.Client/src/packages/core/workspace/components/workspace-split-view/workspace-split-view-variant-selector.element.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

UmbWorkspaceSplitViewVariantSelectorElement.render has a cyclomatic complexity of 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 120 in src/Umbraco.Web.UI.Client/src/packages/core/workspace/components/workspace-split-view/workspace-split-view-variant-selector.element.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

UmbWorkspaceSplitViewVariantSelectorElement.constructor has a cyclomatic complexity of 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.