Property Editors: Improve Missing Property Editor UI and allow save/publish#20104
Merged
iOvergaard merged 31 commits intomainfrom Sep 18, 2025
Merged
Conversation
…EditorCollection
…d when an editor is not found
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…n.MapValueViewModels()`
…a string (same as the Label did previously)
…ing editor Same logic as for when the property is readonly.
Base automatically changed from
v16/feature/non-existing-property-editor
to
main
September 10, 2025 09:20
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the handling of missing property editors to allow content saving even when properties contain editors that are no longer available. The changes improve the user experience by replacing modal dialogs with collapsible UI elements and providing more detailed information about missing property types.
Key changes:
- Modified property validation to handle missing property editors gracefully rather than throwing exceptions
- Replaced modal-based UI with collapsible details display in the missing property editor component
- Updated localization strings to provide clearer guidance to users
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| PropertyValidationService.cs | Added fallback to MissingPropertyEditor when property editor is not found, allowing validation to proceed |
| PropertyValidationServiceTests.cs | Added test for missing property editor validation and updated constructor calls |
| VariationTests.cs | Updated PropertyValidationService constructor call to include new parameter |
| ContentEditingServiceBase.cs | Modified to return existing property value instead of null when property editor is missing |
| property-editor-ui-missing.element.ts | Completely redesigned UI from modal-based to collapsible details with data type information |
| Multiple modal files | Removed modal-related code as it's no longer needed |
| Language files | Updated localization strings for the new UI approach |
tests/Umbraco.Tests.UnitTests/Umbraco.Infrastructure/Services/PropertyValidationServiceTests.cs
Show resolved
Hide resolved
kjac
reviewed
Sep 17, 2025
tests/Umbraco.Tests.UnitTests/Umbraco.Infrastructure/Services/PropertyValidationServiceTests.cs
Outdated
Show resolved
Hide resolved
lauraneto
changed the title
kjac
reviewed
Sep 17, 2025
kjac
reviewed
Sep 17, 2025
kjac
reviewed
Sep 17, 2025
kjac
reviewed
Sep 17, 2025
kjac
requested changes
Sep 17, 2025
Contributor
kjac
left a comment
kjac
left a comment
There was a problem hiding this comment.
This tests out really great 👍
I left a few comments for you to consider.
lauraneto
changed the title
lauraneto
changed the title
iOvergaard
approved these changes
Sep 18, 2025
iOvergaard
deleted the
v16/feature/non-existing-property-editor-allow-saving
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was done on top of #19997 and adjusts the code so that the document can still be saved, even though it contains missing property editors.
In order to test, follow the steps in #19997 and attempt to save the content.
While working on this ticket I also did some additional UI changes to improve the editor and developer experience, by collapsing the content instead of using a modal and adding more information (data type and property editor alias).
