Skip to content

Feature: Inflight Request Cache for Document Types and Data Types - #19956

Merged
iOvergaard merged 34 commits into
mainfrom
v16/bugfix/inflight-request-cache
Aug 22, 2025
Merged

Feature: Inflight Request Cache for Document Types and Data Types#19956
iOvergaard merged 34 commits into
mainfrom
v16/bugfix/inflight-request-cache

Update src/Umbraco.Web.UI.Client/src/packages/management-api/detail/d…

ac305bb
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Aug 21, 2025 in 44s

CodeScene PR Check

Quality Gate Failed

Gates Failed
Enforce advisory code health rules (2 files with Complex Method)

Gates Passed
3 Quality Gates Passed

See analysis details in CodeScene

Reason for failure
Enforce advisory code health rules Violations Code Health Impact
document-type-detail.server.data-source.ts 1 advisory rule 10.00 → 9.45 Suppress
data-type-detail.server.data-source.ts 1 advisory rule 10.00 → 9.69 Suppress

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method data-type-detail.server.data-source.ts: UmbDataTypeServerDataSource.create
  • Complex Method document-type-detail.server.data-source.ts: UmbDocumentTypeDetailServerDataSource.create
  • Complex Method document-type-detail.server.data-source.ts: UmbDocumentTypeDetailServerDataSource.update

Annotations

Check warning on line 85 in src/Umbraco.Web.UI.Client/src/packages/data-type/repository/detail/server-data-source/data-type-detail.server.data-source.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

UmbDataTypeServerDataSource.create has a cyclomatic complexity of 11, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 136 in src/Umbraco.Web.UI.Client/src/packages/documents/document-types/repository/detail/server-data-source/document-type-detail.server.data-source.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

UmbDocumentTypeDetailServerDataSource.create has a cyclomatic complexity of 11, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 203 in src/Umbraco.Web.UI.Client/src/packages/documents/document-types/repository/detail/server-data-source/document-type-detail.server.data-source.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

UmbDocumentTypeDetailServerDataSource.update has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.