Date and time handling: Use UTC for system dates in Umbraco - #19822
CodeScene PR Check
Quality Gate Failed
(2 files improve in Code Health)
Gates Failed
(1 file with Excess Number of Function Arguments)
Gates Passed
See analysis details in CodeScene
Reason for failure
| Enforce advisory code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| MigrateSystemDatesToUtc.cs | 1 advisory rule | 10.00 → 9.69 | Suppress |
View Improvements
| File | Code Health Impact | Categories Improved |
|---|---|---|
| AuditRepository.cs | 8.68 → 9.54 | Code Duplication, Complex Method |
| MemberUserStore.cs | 4.70 → 4.71 | Complex Method, Overall Code Complexity |
Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.
Details
🚩 Declining Code Health (highest to lowest):
- Excess Number of Function Arguments MigrateSystemDatesToUtc.cs: MigrateDateColumn
✅ Improving Code Health:
- Complex Method MemberUserStore.cs: UpdateMemberProperties
- Overall Code Complexity MemberUserStore.cs
- Code Duplication AuditRepository.cs
- Complex Method AuditRepository.cs: GetPagedResultsByQuery
Annotations
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v17/dev)
✅ No longer an issue: Code Duplication
The module no longer contains too many functions with similar structure
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v17/dev)
✅ No longer an issue: Complex Method
GetPagedResultsByQuery is no longer above the threshold for cyclomatic complexity
Check notice on line 796 in src/Umbraco.Infrastructure/Security/MemberUserStore.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v17/dev)
✅ Getting better: Complex Method
UpdateMemberProperties decreases in cyclomatic complexity from 46 to 44, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 1 in src/Umbraco.Infrastructure/Security/MemberUserStore.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v17/dev)
✅ Getting better: Overall Code Complexity
The mean cyclomatic complexity decreases from 5.30 to 5.22, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v17/dev)
❌ New issue: Excess Number of Function Arguments
MigrateDateColumn has 5 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.