Make logging more friendly for docker #19818
CodeScene PR Check
Quality Gate Failed
(1 files improve in Code Health)
Gates Failed
(1 new file with code health below 9.00)
(1 file with Code Duplication, Primitive Obsession, Excess Number of Function Arguments)
Gates Passed
See analysis details in CodeScene
Reason for failure
| New code is healthy | Violations | Code Health Impact | |
|---|---|---|---|
| LogViewerServiceBase.cs | 3 rules | 10.00 → 8.82 | Suppress |
| Enforce advisory code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| LogViewerServiceBase.cs | 3 advisory rules | 10.00 → 8.82 | Suppress |
View Improvements
| File | Code Health Impact | Categories Improved |
|---|---|---|
| LogViewerService.cs | 8.82 → 10.00 | Code Duplication, Primitive Obsession, Excess Number of Function Arguments |
Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.
Details
🚩 Declining Code Health (highest to lowest):
- Code Duplication LogViewerServiceBase.cs
- Primitive Obsession LogViewerServiceBase.cs
- Excess Number of Function Arguments LogViewerServiceBase.cs: GetPagedLogsAsync
- Excess Number of Function Arguments LogViewerServiceBase.cs: GetFilteredLogs
✅ Improving Code Health:
- Code Duplication LogViewerService.cs
- Primitive Obsession LogViewerService.cs
- Excess Number of Function Arguments LogViewerService.cs: GetPagedLogsAsync
- Excess Number of Function Arguments LogViewerService.cs: GetFilteredLogs
Annotations
Check notice on line 1 in src/Umbraco.Core/Services/LogViewerService.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Code Duplication
The module no longer contains too many functions with similar structure
Check notice on line 1 in src/Umbraco.Core/Services/LogViewerService.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Primitive Obsession
The ratio of primivite types in function arguments is no longer above the threshold
Check notice on line 30 in src/Umbraco.Core/Services/LogViewerService.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Excess Number of Function Arguments
GetPagedLogsAsync is no longer above the threshold for number of arguments
Check notice on line 79 in src/Umbraco.Core/Services/LogViewerService.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Excess Number of Function Arguments
GetFilteredLogs is no longer above the threshold for number of arguments
Check warning on line 84 in src/Umbraco.Core/Services/LogViewerServiceBase.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Code Duplication
The module contains 4 functions with similar structure: AddSavedLogQueryAsync,DeleteSavedLogQueryAsync,GetLogLevelCountsAsync,GetMessageTemplatesAsync. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.
Check warning on line 1 in src/Umbraco.Core/Services/LogViewerServiceBase.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Primitive Obsession
In this module, 50.0% of all function arguments are primitive types, threshold = 30.0%. The functions in this file have too many primitive types (e.g. int, double, float) in their function argument lists. Using many primitive types lead to the code smell Primitive Obsession. Avoid adding more primitive arguments.
Check warning on line 188 in src/Umbraco.Core/Services/LogViewerServiceBase.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Excess Number of Function Arguments
GetPagedLogsAsync has 7 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
Check warning on line 268 in src/Umbraco.Core/Services/LogViewerServiceBase.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Excess Number of Function Arguments
GetFilteredLogs has 6 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.