Skip to content

Template with Block List field with Inline Editing Mode causes Collection List View to shrink - #19754

Merged
AndyButland merged 1 commit into
mainfrom
v16/fix-bug/template-is-shrunk
Jul 21, 2025
Merged

Template with Block List field with Inline Editing Mode causes Collection List View to shrink#19754
AndyButland merged 1 commit into
mainfrom
v16/fix-bug/template-is-shrunk

Fix issue template is shrunk when enable inline editing mode in colle…

60dbabc
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Jul 18, 2025 in 26s

CodeScene PR Check

Quality Gate Failed

Gates Failed
Prevent hotspot decline (1 hotspot with Complex Method)
Enforce advisory code health rules (1 file with Complex Method)

Gates Passed
2 Quality Gates Passed

See analysis details in CodeScene

Reason for failure
Prevent hotspot decline Violations Code Health Impact
block-workspace.context.ts 1 rule in this hotspot 6.95 → 6.94 Suppress
Enforce advisory code health rules Violations Code Health Impact
block-workspace.context.ts 1 advisory rule 6.95 → 6.94 Suppress

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method block-workspace.context.ts: UmbBlockWorkspaceContext.gotManager 🔥

Annotations

Check warning on line 218 in src/Umbraco.Web.UI.Client/src/packages/block/block/workspace/block-workspace.context.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method

UmbBlockWorkspaceContext.gotManager increases in cyclomatic complexity from 17 to 20, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.