Skip to content

Add support for programmatic creation of property types providing the data type key#19720

Merged
kjac merged 2 commits into
v13/devfrom
v13/bugfix/support-use-of-data-type-key-when-creating-property-types-programatically
Jul 15, 2025
Merged

Add support for programmatic creation of property types providing the data type key#19720
kjac merged 2 commits into
v13/devfrom
v13/bugfix/support-use-of-data-type-key-when-creating-property-types-programatically

Add integration tests

296e8de
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (v13/dev) failed Jul 15, 2025 in 1m 8s

CodeScene PR Check

Quality Gate Failed

Gates Failed
Enforce advisory code health rules (1 file with Lines of Code in a Single File)

Gates Passed
3 Quality Gates Passed

See analysis details in CodeScene

Reason for failure
Enforce advisory code health rules Violations Code Health Impact
ContentTypeRepositoryBase.cs 1 advisory rule 3.83 → 3.63 Suppress

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

Details

🚩 Declining Code Health (highest to lowest):

  • Lines of Code in a Single File ContentTypeRepositoryBase.cs

✅ Improving Code Health:

  • Primitive Obsession ContentTypeRepositoryBase.cs

Annotations

Check warning on line 1 in src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeRepositoryBase.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/dev)

❌ New issue: Lines of Code in a Single File

This module has 1020 lines of code, improve code health by reducing it to 1000. The number of Lines of Code in a single file. More Lines of Code lowers the code health.

Check notice on line 1 in src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeRepositoryBase.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/dev)

✅ Getting better: Primitive Obsession

The ratio of primitive types in function arguments decreases from 32.69% to 32.08%, threshold = 30.0%. The functions in this file have too many primitive types (e.g. int, double, float) in their function argument lists. Using many primitive types lead to the code smell Primitive Obsession. Avoid adding more primitive arguments.