Skip to content

Parse update date before sorting in media list view #19711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leekelleher merged 2 commits into from
Jul 16, 2025
Merged

Parse update date before sorting in media list view #19711

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b85548f
Parse update date before sorting in media list view.
AndyButland Jul 11, 2025
fcb74d1
Moved function placement.
AndyButland Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/Umbraco.Web.UI.Client/src/common/directives/components/umbmediagrid.directive.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,14 +351,17 @@
// sort function
scope.sortBy = function (item) {
if (scope.sortColumn === "updateDate") {
return [-item['isFolder'],item['updateDate']];
return [-item['isFolder'],parseUpdateDate(item['updateDate'])];
}
else {
return [-item['isFolder'],item['name']];
}
};


function parseUpdateDate(date) {
var parsedDate = Date.parse(date);
return isNaN(parsedDate) ? date : parsedDate;
}

Check warning on line 364 in src/Umbraco.Web.UI.Client/src/common/directives/components/umbmediagrid.directive.js

View check run for this annotation

CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (v13/dev)

❌ Getting worse: Complex Method 

MediaGridDirective.link increases in cyclomatic complexity from 46 to 47, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
}

var directive = {
Expand Down
Loading