Skip to content

V16 QA Reverted npx command #19699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nhudinh0309 merged 3 commits into from
Jul 9, 2025
Merged

V16 QA Reverted npx command #19699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f615ca9
Reverted npx command
nhudinh0309 Jul 9, 2025
cd7de1f
Fixed npx command
nhudinh0309 Jul 9, 2025
5af8013
Fixed failed tests related to document type folder
nhudinh0309 Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/Umbraco.Tests.AcceptanceTest/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"testSqlite": "npx playwright test DefaultConfig --grep-invert \"Users\"",
"all": "npx playwright test",
"createTest": "node createTest.js",
"smokeTest": "npx playwright test DefaultConfig/Users/Permissions/UserGroup/GranularPermissionsInContent",
"smokeTest": "npx playwright test DefaultConfig --grep \"@smoke\"",
"smokeTestSqlite": "npx playwright test DefaultConfig --grep \"@smoke\" --grep-invert \"Users\""
},
"devDependencies": {
Expand Down
14 changes: 6 additions & 8 deletions ...Tests.AcceptanceTest/tests/DefaultConfig/Settings/DocumentType/DocumentTypeFolder.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,9 @@ test('can create a empty document type folder', {tag: '@smoke'}, async ({umbraco

// Assert
await umbracoUi.documentType.waitForDocumentTypeToBeCreated();
const folder = await umbracoApi.documentType.getByName(documentFolderName);
expect(folder.name).toBe(documentFolderName);
expect(await umbracoApi.documentType.doesNameExist(documentFolderName)).toBeTruthy();
// Checks if the folder is in the root
await umbracoUi.documentType.reloadTree('Document Types');
await umbracoUi.documentType.clickCaretButtonForName('Document Types');
await umbracoUi.documentType.isDocumentTreeItemVisible(documentFolderName);
});

Expand All @@ -42,7 +41,7 @@ test('can delete a document type folder', {tag: '@smoke'}, async ({umbracoApi, u

// Assert
await umbracoUi.documentType.waitForDocumentTypeToBeDeleted();
await umbracoApi.documentType.doesNameExist(documentFolderName);
expect(await umbracoApi.documentType.doesNameExist(documentFolderName)).toBeFalsy();
await umbracoUi.documentType.isDocumentTreeItemVisible(documentFolderName, false);
});

Expand All @@ -62,8 +61,8 @@ test('can rename a document type folder', async ({umbracoApi, umbracoUi}) => {

// Assert
await umbracoUi.documentType.waitForDocumentTypeToBeRenamed();
const folder = await umbracoApi.documentType.getByName(documentFolderName);
expect(folder.name).toBe(documentFolderName);
expect(await umbracoApi.documentType.doesNameExist(oldFolderName)).toBeFalsy();
expect(await umbracoApi.documentType.doesNameExist(documentFolderName)).toBeTruthy();
await umbracoUi.documentType.isDocumentTreeItemVisible(oldFolderName, false);
await umbracoUi.documentType.isDocumentTreeItemVisible(documentFolderName);
});
Expand All @@ -85,8 +84,7 @@ test('can create a document type folder in a folder', async ({umbracoApi, umbrac

// Assert
await umbracoUi.documentType.waitForDocumentTypeToBeCreated();
const folder = await umbracoApi.documentType.getByName(childFolderName);
expect(folder.name).toBe(childFolderName);
expect(await umbracoApi.documentType.doesNameExist(childFolderName)).toBeTruthy();
// Checks if the parentFolder contains the ChildFolder as a child
const parentFolder = await umbracoApi.documentType.getChildren(parentFolderId);
expect(parentFolder[0].name).toBe(childFolderName);
Expand Down