#16772 partial fix backoffice redirect after login#19663
#16772 partial fix backoffice redirect after login#19663AndyButland merged 2 commits intoumbraco:v13/devfrom
Conversation
|
Hi there @kows, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
AndyButland
left a comment
There was a problem hiding this comment.
Thanks for this @kows - I've verified that it works for local login and also when I've registered and external login provider (Google). Will merge in and include in 13.10.
|
I'm not sure this is working, or at least it's creating an odd side effect for us:
I'm not seeing the issue if I drop the version back to 13.9.3 |
|
@AndyButland we are seeing the same issue as mentioned above by @AdTarling |
|
Should be resolved for 13.11 - see #19984 (linked above). |
With the mindset of better anything than nothing: partial fix for #16772
Seems to enable login screen for local (hash needed) and OpenId login (reason for encoding).
This does not fix the flow when
AutoRedirectLoginToExternalProvideris enabled since I have no idea yet how I would get the anchor value serverside or work around that issue.