Skip to content

#16772 partial fix backoffice redirect after login#19663

Merged
AndyButland merged 2 commits intoumbraco:v13/devfrom
kows:v13/bugfix/login-redirect
Jul 7, 2025
Merged

#16772 partial fix backoffice redirect after login#19663
AndyButland merged 2 commits intoumbraco:v13/devfrom
kows:v13/bugfix/login-redirect

Conversation

@kows
Copy link
Copy Markdown

@kows kows commented Jul 3, 2025

With the mindset of better anything than nothing: partial fix for #16772
Seems to enable login screen for local (hash needed) and OpenId login (reason for encoding).
This does not fix the flow when AutoRedirectLoginToExternalProvider is enabled since I have no idea yet how I would get the anchor value serverside or work around that issue.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 3, 2025

Hi there @kows, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@emmagarland
Copy link
Copy Markdown
Collaborator

Hi @kows

Thanks for your PR and the replication steps to partially fix for local #16772, regarding the backoffice login redirect.

One of the Core Collaborators team will review this as soon as possible.

Also, great stuff that this is your first time contribution! #h5yr

Best wishes

Emma

Copy link
Copy Markdown
Contributor

@AndyButland AndyButland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @kows - I've verified that it works for local login and also when I've registered and external login provider (Google). Will merge in and include in 13.10.

@AdTarling
Copy link
Copy Markdown

AdTarling commented Sep 22, 2025

I'm not sure this is working, or at least it's creating an odd side effect for us:

I'm not seeing the issue if I drop the version back to 13.9.3

@orangejuice-sjaak
Copy link
Copy Markdown

@AndyButland we are seeing the same issue as mentioned above by @AdTarling

@AndyButland
Copy link
Copy Markdown
Contributor

Should be resolved for 13.11 - see #19984 (linked above).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants