Skip to content

Comments

Label property-editor, adds UFM template support#19610

Merged
iOvergaard merged 10 commits intomainfrom
v16/feature/label-editor-ufm
Jun 30, 2025
Merged

Label property-editor, adds UFM template support#19610
iOvergaard merged 10 commits intomainfrom
v16/feature/label-editor-ufm

Conversation

@leekelleher
Copy link
Member

Description

Adds a "Label template configuration field to the Label property-editor UI, to add support for UFM syntax.

Under the hood, if a label template is set, the <umb-ufm-render> component is used to render the label's value, this can be used in conjunction with UFM filter syntax.

Note

To note, this pull request is only the client-side implementation. A follow-up pull request will be made with the server-side feature to add a new data-type (specifically for file-size and pixels), as well as any other required database creation amends.

How to test?

An initial example would be the file-size property on a media item. Navigate to the data-type called "Label (bigint)", in the label template field, add the following: {=value | bytes}. Then navigate to any media item, notice that the file-size is now displayed in the appropriate byte size unit.

Copilot AI review requested due to automatic review settings June 25, 2025 16:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for Umbraco Flavored Markdown (UFM) in the Label property editor by introducing a label template field and a new bytes filter.

  • Registers and implements a bytes UFM filter using formatBytes
  • Updates the Label UI element to accept a labelTemplate setting and render via <umb-ufm-render>
  • Extends the Label property editor manifest to expose the new labelTemplate configuration

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/Umbraco.Web.UI.Client/src/packages/ufm/filters/manifests.ts Register new Umb.Filter.Bytes filter
src/Umbraco.Web.UI.Client/src/packages/ufm/filters/bytes.filter.ts Implement bytes filter calling formatBytes
src/Umbraco.Web.UI.Client/src/packages/property-editors/label/property-editor-ui-label.element.ts Add labelTemplate state, conditional UFM rendering
src/Umbraco.Web.UI.Client/src/packages/property-editors/label/manifests.ts Add labelTemplate to Label property-editor settings
Comments suppressed due to low confidence (1)

src/Umbraco.Web.UI.Client/src/packages/property-editors/label/property-editor-ui-label.element.ts:32

  • [nitpick] Removing the default UmbTextStyles may cause inconsistent typography across the backoffice. Consider re-adding or replacing these styles to maintain consistent label styling.
	}

@iOvergaard iOvergaard enabled auto-merge (squash) June 30, 2025 07:54
leekelleher added a commit that referenced this pull request Sep 2, 2025
The server-side migration to compliment the client-side feature #19610
leekelleher added a commit that referenced this pull request Sep 2, 2025
The server-side migration to compliment the client-side feature #19610
kjac added a commit that referenced this pull request Sep 3, 2025
* Database creation/migration for Label editor data-type

The server-side migration to compliment the client-side feature #19610

* Update src/Umbraco.Infrastructure/Migrations/Upgrade/V_16_3_0/MigrateMediaTypeLabelProperties.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Updated integration test with new data-type items count

* Update src/Umbraco.Infrastructure/Migrations/Install/DatabaseDataCreator.cs

Co-authored-by: Kenn Jacobsen <kja@umbraco.dk>

* Apply suggestion from @kjac

Co-authored-by: Kenn Jacobsen <kja@umbraco.dk>

* Apply suggestion from @kjac

Co-authored-by: Kenn Jacobsen <kja@umbraco.dk>

* Apply suggestion from @kjac

Co-authored-by: Kenn Jacobsen <kja@umbraco.dk>

* Apply suggestion from @kjac

Co-authored-by: Kenn Jacobsen <kja@umbraco.dk>

* Apply suggestion from @kjac

Co-authored-by: Kenn Jacobsen <kja@umbraco.dk>

* Updated to use `switch` pattern matching

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Kenn Jacobsen <kja@umbraco.dk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants