Avoid async await Task.FromResult, plus some other minor tweaks#19597
Avoid async await Task.FromResult, plus some other minor tweaks#19597AndyButland merged 1 commit intoumbraco:mainfrom
Conversation
|
Hi there @Henr1k80, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
AndyButland
left a comment
There was a problem hiding this comment.
Thanks very much @Henr1k80 - all looks good to me, so merging in and will be part of 16.1.
Prerequisites
There are still some unneeded awaits left from the cleanup in #16535 (was maybe in #18901)
I have also added some minor tweaks on private methods like static, use the actual type instead of interfaces to avoid looking for implementations and use async overloads when possible.