Skip to content

V16: Adds a state for "forbidden" for entities that return 403 (Access denied) - #19557

Merged
leekelleher merged 22 commits into
mainfrom
v16/feature/forbidden-route
Jun 30, 2025
Merged

V16: Adds a state for "forbidden" for entities that return 403 (Access denied)#19557
leekelleher merged 22 commits into
mainfrom
v16/feature/forbidden-route

Merge branch 'main' into v16/feature/forbidden-route

a90a7f3
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Jun 26, 2025 in 1m 9s

CodeScene PR Check

Quality Gate Failed

Gates Failed
Enforce advisory code health rules (3 files with Complex Method)

Gates Passed
3 Quality Gates Passed

See analysis details in CodeScene

Reason for failure
Enforce advisory code health rules Violations Code Health Impact
media-workspace-editor.element.ts 1 advisory rule 10.00 → 9.69 Suppress
document-blueprint-workspace-editor.element.ts 1 advisory rule 10.00 → 9.69 Suppress
document-workspace-editor.element.ts 1 advisory rule 9.51 → 9.49 Suppress

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method document-workspace-editor.element.ts: UmbDocumentWorkspaceEditorElement.generateRoutes
  • Complex Method document-blueprint-workspace-editor.element.ts: UmbDocumentBlueprintWorkspaceEditorElement._generateRoutes
  • Complex Method media-workspace-editor.element.ts: UmbMediaWorkspaceEditorElement._generateRoutes

Annotations

Check warning on line 148 in src/Umbraco.Web.UI.Client/src/packages/documents/documents/workspace/document-workspace-editor.element.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method

UmbDocumentWorkspaceEditorElement.generateRoutes increases in cyclomatic complexity from 12 to 13, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 111 in src/Umbraco.Web.UI.Client/src/packages/media/media/workspace/media-workspace-editor.element.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

UmbMediaWorkspaceEditorElement._generateRoutes has a cyclomatic complexity of 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 113 in src/Umbraco.Web.UI.Client/src/packages/documents/document-blueprints/workspace/document-blueprint-workspace-editor.element.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

UmbDocumentBlueprintWorkspaceEditorElement._generateRoutes has a cyclomatic complexity of 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.