Skip to content

Add a warning to the CreateContentFromBlueprint method xml docs#19542

Merged
AndyButland merged 1 commit intov13/mainfrom
v13/bugfix/19352-CreateContentFromBlueprint-does-not-replace-block-ids
Jun 13, 2025
Merged

Add a warning to the CreateContentFromBlueprint method xml docs#19542
AndyButland merged 1 commit intov13/mainfrom
v13/bugfix/19352-CreateContentFromBlueprint-does-not-replace-block-ids

Conversation

@lauraneto
Copy link
Contributor

Closes #19352

A proper fix was done for V16 in #19528, but for V13 it would be more tricky as we wouldn't want to introduce new methods or a behavioral change. Instead, a remark was added to the method's xml docs to warn users.

Copilot AI review requested due to automatic review settings June 12, 2025 15:02
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a warning remark to the XML documentation of the CreateContentFromBlueprint method to alert users about the need to trigger a notification for regenerating block ids when saving content from a blueprint.

  • Added a warning remark in IContentService.cs.
  • Added an tag in ContentService.cs that may inherit the updated XML docs.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/Umbraco.Core/Services/IContentService.cs Adds a warning remark to the XML docs for the CreateContentFromBlueprint method.
src/Umbraco.Core/Services/ContentService.cs Updates the method implementation to inherit XML docs via .
Comments suppressed due to low confidence (1)

src/Umbraco.Core/Services/ContentService.cs:3630

  • Ensure that the inherited XML documentation includes the new warning remarks from the interface. If there is any risk that documentation generators may omit this note, consider adding the warning explicitly here.
/// <inheritdoc />

Copy link
Contributor

@AndyButland AndyButland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lauraneto. Looks good to me and is a sensible approach for 13 I believe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using a blueprint with blocks already in them to create content duplicates the ID's of the blocks.

2 participants