Skip to content

add const for content section alias #19484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nielslyngsoe wants to merge 2 commits into from
Closed

add const for content section alias #19484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cad596f
add const for content section alias
nielslyngsoe Jun 4, 2025
493b62d
Merge branch 'main' into v16/feature/content-section-alias-const
nielslyngsoe Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Umbraco.Web.UI.Client/examples/custom-modal/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import type { ManifestDashboard } from '@umbraco-cms/backoffice/dashboard';
import type { ManifestModal } from '@umbraco-cms/backoffice/modal';
import { UMB_SECTION_ALIAS_CONDITION_ALIAS } from '@umbraco-cms/backoffice/section';

const demoModal: ManifestModal = {
type: 'modal',
Expand All @@ -20,7 +21,7 @@ const demoModalsDashboard: ManifestDashboard = {
},
conditions: [
{
alias: 'Umb.Condition.SectionAlias',
alias: UMB_SECTION_ALIAS_CONDITION_ALIAS,
match: 'Umb.Section.Content',
},
],
Expand Down
3 changes: 2 additions & 1 deletion src/Umbraco.Web.UI.Client/examples/validation-context/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import type { ManifestDashboard } from '@umbraco-cms/backoffice/dashboard';
import { UMB_SECTION_ALIAS_CONDITION_ALIAS } from '@umbraco-cms/backoffice/section';

const dashboard: ManifestDashboard = {
type: 'dashboard',
Expand All @@ -12,7 +13,7 @@ const dashboard: ManifestDashboard = {
},
conditions: [
{
alias: 'Umb.Condition.SectionAlias',
alias: UMB_SECTION_ALIAS_CONDITION_ALIAS,
match: 'Umb.Section.Content',
},
],
Expand Down
1 change: 1 addition & 0 deletions src/Umbraco.Web.UI.Client/src/packages/core/section/conditions/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
export const UMB_SECTION_USER_PERMISSION_CONDITION_ALIAS = 'Umb.Condition.SectionUserPermission';
export const UMB_SECTION_ALIAS_CONDITION_ALIAS = 'Umb.Condition.SectionAlias';
4 changes: 2 additions & 2 deletions src/Umbraco.Web.UI.Client/src/packages/core/section/conditions/manifests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { UMB_SECTION_USER_PERMISSION_CONDITION_ALIAS } from './constants.js';
import { UMB_SECTION_ALIAS_CONDITION_ALIAS, UMB_SECTION_USER_PERMISSION_CONDITION_ALIAS } from './constants.js';
import { UmbSectionAliasCondition } from './section-alias.condition.js';
import { UmbSectionUserPermissionCondition } from './section-user-permission.condition.js';

Expand All @@ -12,7 +12,7 @@ export const manifests: Array<UmbExtensionManifest> = [
{
type: 'condition',
name: 'Section Alias Condition',
alias: 'Umb.Condition.SectionAlias',
alias: UMB_SECTION_ALIAS_CONDITION_ALIAS,
api: UmbSectionAliasCondition,
},
];
3 changes: 2 additions & 1 deletion src/Umbraco.Web.UI.Client/src/packages/dictionary/dashboard/manifests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { UMB_SECTION_ALIAS_CONDITION_ALIAS } from '@umbraco-cms/backoffice/section';
import { UMB_TRANSLATION_SECTION_ALIAS } from '@umbraco-cms/backoffice/translation';

export const manifests: Array<UmbExtensionManifest> = [
Expand All @@ -12,7 +13,7 @@ export const manifests: Array<UmbExtensionManifest> = [
},
conditions: [
{
alias: 'Umb.Condition.SectionAlias',
alias: UMB_SECTION_ALIAS_CONDITION_ALIAS,
match: UMB_TRANSLATION_SECTION_ALIAS,
},
],
Expand Down
3 changes: 2 additions & 1 deletion src/Umbraco.Web.UI.Client/src/packages/documents/document-redirect-management/manifests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { UMB_CONTENT_SECTION_ALIAS } from '@umbraco-cms/backoffice/content';
import { UMB_SECTION_ALIAS_CONDITION_ALIAS } from '@umbraco-cms/backoffice/section';

export const manifests: Array<UmbExtensionManifest> = [
{
Expand All @@ -13,7 +14,7 @@ export const manifests: Array<UmbExtensionManifest> = [
},
conditions: [
{
alias: 'Umb.Condition.SectionAlias',
alias: UMB_SECTION_ALIAS_CONDITION_ALIAS,
match: UMB_CONTENT_SECTION_ALIAS,
},
],
Expand Down
7 changes: 5 additions & 2 deletions src/Umbraco.Web.UI.Client/src/packages/documents/section/manifests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
import { UMB_CONTENT_SECTION_ALIAS } from '@umbraco-cms/backoffice/content';
import { UMB_DOCUMENT_ROOT_ENTITY_TYPE, UMB_CONTENT_MENU_ALIAS } from '@umbraco-cms/backoffice/document';
import { UMB_SECTION_USER_PERMISSION_CONDITION_ALIAS } from '@umbraco-cms/backoffice/section';
import {
UMB_SECTION_ALIAS_CONDITION_ALIAS,
UMB_SECTION_USER_PERMISSION_CONDITION_ALIAS,
} from '@umbraco-cms/backoffice/section';

export const manifests: Array<UmbExtensionManifest> = [
{
Expand Down Expand Up @@ -32,7 +35,7 @@ export const manifests: Array<UmbExtensionManifest> = [
},
conditions: [
{
alias: 'Umb.Condition.SectionAlias',
alias: UMB_SECTION_ALIAS_CONDITION_ALIAS,
match: UMB_CONTENT_SECTION_ALIAS,
},
],
Expand Down
3 changes: 2 additions & 1 deletion src/Umbraco.Web.UI.Client/src/packages/health-check/manifests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { UMB_SECTION_ALIAS_CONDITION_ALIAS } from '@umbraco-cms/backoffice/section';
import { UMB_SETTINGS_SECTION_ALIAS } from '@umbraco-cms/backoffice/settings';

export const manifests: Array<UmbExtensionManifest> = [
Expand All @@ -14,7 +15,7 @@ export const manifests: Array<UmbExtensionManifest> = [
},
conditions: [
{
alias: 'Umb.Condition.SectionAlias',
alias: UMB_SECTION_ALIAS_CONDITION_ALIAS,
match: UMB_SETTINGS_SECTION_ALIAS,
},
],
Expand Down
3 changes: 2 additions & 1 deletion src/Umbraco.Web.UI.Client/src/packages/language/app-language-select/manifests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { UMB_CONTENT_SECTION_ALIAS } from '@umbraco-cms/backoffice/content';
import { UMB_SECTION_ALIAS_CONDITION_ALIAS } from '@umbraco-cms/backoffice/section';
export const manifests: Array<UmbExtensionManifest> = [
{
type: 'sectionSidebarApp',
Expand All @@ -8,7 +9,7 @@ export const manifests: Array<UmbExtensionManifest> = [
weight: 900,
conditions: [
{
alias: 'Umb.Condition.SectionAlias',
alias: UMB_SECTION_ALIAS_CONDITION_ALIAS,
match: UMB_CONTENT_SECTION_ALIAS,
},
{
Expand Down
7 changes: 5 additions & 2 deletions src/Umbraco.Web.UI.Client/src/packages/media/media-section/manifests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
import { UMB_MEDIA_ROOT_ENTITY_TYPE, UMB_MEDIA_MENU_ALIAS } from '../media/index.js';
import { UMB_SECTION_USER_PERMISSION_CONDITION_ALIAS } from '@umbraco-cms/backoffice/section';
import {
UMB_SECTION_ALIAS_CONDITION_ALIAS,
UMB_SECTION_USER_PERMISSION_CONDITION_ALIAS,
} from '@umbraco-cms/backoffice/section';

const sectionAlias = 'Umb.Section.Media';

Expand Down Expand Up @@ -33,7 +36,7 @@ export const manifests: Array<UmbExtensionManifest> = [
},
conditions: [
{
alias: 'Umb.Condition.SectionAlias',
alias: UMB_SECTION_ALIAS_CONDITION_ALIAS,
match: sectionAlias,
},
],
Expand Down
4 changes: 3 additions & 1 deletion src/Umbraco.Web.UI.Client/src/packages/media/media/dashboard/manifests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import { UMB_SECTION_ALIAS_CONDITION_ALIAS } from '@umbraco-cms/backoffice/section';

export const manifests: Array<UmbExtensionManifest> = [
{
type: 'dashboard',
Expand All @@ -11,7 +13,7 @@ export const manifests: Array<UmbExtensionManifest> = [
},
conditions: [
{
alias: 'Umb.Condition.SectionAlias',
alias: UMB_SECTION_ALIAS_CONDITION_ALIAS,
match: 'Umb.Section.Media',
},
],
Expand Down
3 changes: 2 additions & 1 deletion src/Umbraco.Web.UI.Client/src/packages/members/section/sidebar-app/manifests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { UMB_MEMBER_MANAGEMENT_SECTION_ALIAS } from '../constants.js';
import { UMB_MEMBER_MANAGEMENT_MENU_ALIAS } from '../menu/index.js';
import { UMB_SECTION_ALIAS_CONDITION_ALIAS } from '@umbraco-cms/backoffice/section';

export const manifests: Array<UmbExtensionManifest> = [
{
Expand All @@ -14,7 +15,7 @@ export const manifests: Array<UmbExtensionManifest> = [
},
conditions: [
{
alias: 'Umb.Condition.SectionAlias',
alias: UMB_SECTION_ALIAS_CONDITION_ALIAS,
match: UMB_MEMBER_MANAGEMENT_SECTION_ALIAS,
},
],
Expand Down
3 changes: 2 additions & 1 deletion src/Umbraco.Web.UI.Client/src/packages/models-builder/manifests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { UMB_SECTION_ALIAS_CONDITION_ALIAS } from '@umbraco-cms/backoffice/section';
import { UMB_SETTINGS_SECTION_ALIAS } from '@umbraco-cms/backoffice/settings';

export const manifests: Array<UmbExtensionManifest> = [
Expand All @@ -13,7 +14,7 @@ export const manifests: Array<UmbExtensionManifest> = [
},
conditions: [
{
alias: 'Umb.Condition.SectionAlias',
alias: UMB_SECTION_ALIAS_CONDITION_ALIAS,
match: UMB_SETTINGS_SECTION_ALIAS,
},
],
Expand Down
11 changes: 7 additions & 4 deletions src/Umbraco.Web.UI.Client/src/packages/packages/package-section/manifests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
import { UMB_SECTION_USER_PERMISSION_CONDITION_ALIAS } from '@umbraco-cms/backoffice/section';
import {
UMB_SECTION_ALIAS_CONDITION_ALIAS,
UMB_SECTION_USER_PERMISSION_CONDITION_ALIAS,
} from '@umbraco-cms/backoffice/section';

const sectionAlias = 'Umb.Section.Packages';

Expand Down Expand Up @@ -32,7 +35,7 @@ export const manifests: Array<UmbExtensionManifest> = [
},
conditions: [
{
alias: 'Umb.Condition.SectionAlias',
alias: UMB_SECTION_ALIAS_CONDITION_ALIAS,
match: sectionAlias,
},
],
Expand All @@ -50,7 +53,7 @@ export const manifests: Array<UmbExtensionManifest> = [
},
conditions: [
{
alias: 'Umb.Condition.SectionAlias',
alias: UMB_SECTION_ALIAS_CONDITION_ALIAS,
match: sectionAlias,
},
],
Expand All @@ -68,7 +71,7 @@ export const manifests: Array<UmbExtensionManifest> = [
},
conditions: [
{
alias: 'Umb.Condition.SectionAlias',
alias: UMB_SECTION_ALIAS_CONDITION_ALIAS,
match: sectionAlias,
},
],
Expand Down
3 changes: 2 additions & 1 deletion src/Umbraco.Web.UI.Client/src/packages/performance-profiling/manifests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { UMB_SECTION_ALIAS_CONDITION_ALIAS } from '@umbraco-cms/backoffice/section';
import { UMB_SETTINGS_SECTION_ALIAS } from '@umbraco-cms/backoffice/settings';

export const manifests = [
Expand All @@ -13,7 +14,7 @@ export const manifests = [
},
conditions: [
{
alias: 'Umb.Condition.SectionAlias',
alias: UMB_SECTION_ALIAS_CONDITION_ALIAS,
match: UMB_SETTINGS_SECTION_ALIAS,
},
],
Expand Down
3 changes: 2 additions & 1 deletion src/Umbraco.Web.UI.Client/src/packages/publish-cache/manifests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { UMB_SECTION_ALIAS_CONDITION_ALIAS } from '@umbraco-cms/backoffice/section';
import { UMB_SETTINGS_SECTION_ALIAS } from '@umbraco-cms/backoffice/settings';

export const manifests = [
Expand All @@ -13,7 +14,7 @@ export const manifests = [
},
conditions: [
{
alias: 'Umb.Condition.SectionAlias',
alias: UMB_SECTION_ALIAS_CONDITION_ALIAS,
match: UMB_SETTINGS_SECTION_ALIAS,
},
],
Expand Down
3 changes: 2 additions & 1 deletion src/Umbraco.Web.UI.Client/src/packages/search/manifests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { manifests as examineManifests } from './examine-management-dashboard/manifests.js';
import { UMB_SECTION_ALIAS_CONDITION_ALIAS } from '@umbraco-cms/backoffice/section';
import { UMB_SETTINGS_SECTION_ALIAS } from '@umbraco-cms/backoffice/settings';

export const manifests: Array<UmbExtensionManifest> = [
Expand Down Expand Up @@ -32,7 +33,7 @@ export const manifests: Array<UmbExtensionManifest> = [
},
conditions: [
{
alias: 'Umb.Condition.SectionAlias',
alias: UMB_SECTION_ALIAS_CONDITION_ALIAS,
match: UMB_SETTINGS_SECTION_ALIAS,
},
],
Expand Down
3 changes: 2 additions & 1 deletion src/Umbraco.Web.UI.Client/src/packages/settings/advanced/manifests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { UMB_SETTINGS_SECTION_ALIAS } from '../constants.js';
import { UMB_ADVANCED_SETTINGS_MENU_ALIAS } from './constants.js';
import { UMB_SECTION_ALIAS_CONDITION_ALIAS } from '@umbraco-cms/backoffice/section';

export const manifests = [
{
Expand All @@ -19,7 +20,7 @@ export const manifests = [
},
conditions: [
{
alias: 'Umb.Condition.SectionAlias',
alias: UMB_SECTION_ALIAS_CONDITION_ALIAS,
match: UMB_SETTINGS_SECTION_ALIAS,
},
],
Expand Down
3 changes: 2 additions & 1 deletion src/Umbraco.Web.UI.Client/src/packages/settings/structure/manifests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { UMB_SETTINGS_SECTION_ALIAS } from '../constants.js';
import { UMB_STRUCTURE_SETTINGS_MENU_ALIAS } from './constants.js';
import { UMB_SECTION_ALIAS_CONDITION_ALIAS } from '@umbraco-cms/backoffice/section';
import type { UmbExtensionManifestKind } from '@umbraco-cms/backoffice/extension-registry';

export const manifests: Array<UmbExtensionManifest | UmbExtensionManifestKind> = [
Expand All @@ -20,7 +21,7 @@ export const manifests: Array<UmbExtensionManifest | UmbExtensionManifestKind> =
},
conditions: [
{
alias: 'Umb.Condition.SectionAlias',
alias: UMB_SECTION_ALIAS_CONDITION_ALIAS,
match: UMB_SETTINGS_SECTION_ALIAS,
},
],
Expand Down
3 changes: 2 additions & 1 deletion src/Umbraco.Web.UI.Client/src/packages/settings/welcome/manifests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { UMB_SETTINGS_SECTION_ALIAS } from '../constants.js';
import { UMB_SECTION_ALIAS_CONDITION_ALIAS } from '@umbraco-cms/backoffice/section';
import type { UmbExtensionManifestKind } from '@umbraco-cms/backoffice/extension-registry';
Comment on lines 1 to 3
Copy link

Copilot AI Jun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Group external imports (e.g., '@umbraco-cms/backoffice/section') consistently at the top and separate from local imports to match project import ordering conventions.

Suggested change
import { UMB_SETTINGS_SECTION_ALIAS } from '../constants.js';
import { UMB_SECTION_ALIAS_CONDITION_ALIAS } from '@umbraco-cms/backoffice/section';
import type { UmbExtensionManifestKind } from '@umbraco-cms/backoffice/extension-registry';
import { UMB_SECTION_ALIAS_CONDITION_ALIAS } from '@umbraco-cms/backoffice/section';
import type { UmbExtensionManifestKind } from '@umbraco-cms/backoffice/extension-registry';
import { UMB_SETTINGS_SECTION_ALIAS } from '../constants.js';

Copilot uses AI. Check for mistakes.

export const manifests: Array<UmbExtensionManifest | UmbExtensionManifestKind> = [
Expand All @@ -14,7 +15,7 @@ export const manifests: Array<UmbExtensionManifest | UmbExtensionManifestKind> =
},
conditions: [
{
alias: 'Umb.Condition.SectionAlias',
alias: UMB_SECTION_ALIAS_CONDITION_ALIAS,
match: UMB_SETTINGS_SECTION_ALIAS,
},
],
Expand Down
3 changes: 2 additions & 1 deletion src/Umbraco.Web.UI.Client/src/packages/telemetry/manifests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { UMB_SECTION_ALIAS_CONDITION_ALIAS } from '@umbraco-cms/backoffice/section';
import { UMB_SETTINGS_SECTION_ALIAS } from '@umbraco-cms/backoffice/settings';

export const manifests = [
Expand All @@ -13,7 +14,7 @@ export const manifests = [
},
conditions: [
{
alias: 'Umb.Condition.SectionAlias',
alias: UMB_SECTION_ALIAS_CONDITION_ALIAS,
match: UMB_SETTINGS_SECTION_ALIAS,
},
],
Expand Down
3 changes: 2 additions & 1 deletion src/Umbraco.Web.UI.Client/src/packages/templating/menu/manifests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { UMB_SECTION_ALIAS_CONDITION_ALIAS } from '@umbraco-cms/backoffice/section';
import { UMB_SETTINGS_SECTION_ALIAS } from '@umbraco-cms/backoffice/settings';

export const manifests: Array<UmbExtensionManifest> = [
Expand All @@ -18,7 +19,7 @@ export const manifests: Array<UmbExtensionManifest> = [
},
conditions: [
{
alias: 'Umb.Condition.SectionAlias',
alias: UMB_SECTION_ALIAS_CONDITION_ALIAS,
match: UMB_SETTINGS_SECTION_ALIAS,
},
],
Expand Down
3 changes: 2 additions & 1 deletion src/Umbraco.Web.UI.Client/src/packages/translation/menu/manifests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { UMB_TRANSLATION_SECTION_ALIAS } from '../section/index.js';
import { UMB_TRANSLATION_MENU_ALIAS } from './constants.js';
import { UMB_SECTION_ALIAS_CONDITION_ALIAS } from '@umbraco-cms/backoffice/section';

export const manifests: Array<UmbExtensionManifest> = [
{
Expand All @@ -20,7 +21,7 @@ export const manifests: Array<UmbExtensionManifest> = [
},
conditions: [
{
alias: 'Umb.Condition.SectionAlias',
alias: UMB_SECTION_ALIAS_CONDITION_ALIAS,
match: UMB_TRANSLATION_SECTION_ALIAS,
},
],
Expand Down
3 changes: 2 additions & 1 deletion src/Umbraco.Web.UI.Client/src/packages/umbraco-news/manifests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import type { ManifestDashboard } from '@umbraco-cms/backoffice/dashboard';
import { UMB_CONTENT_SECTION_ALIAS } from '@umbraco-cms/backoffice/content';
import { UMB_SECTION_ALIAS_CONDITION_ALIAS } from '@umbraco-cms/backoffice/section';

export const dashboard: ManifestDashboard = {
type: 'dashboard',
Expand All @@ -12,7 +13,7 @@ export const dashboard: ManifestDashboard = {
},
conditions: [
{
alias: 'Umb.Condition.SectionAlias',
alias: UMB_SECTION_ALIAS_CONDITION_ALIAS,
match: UMB_CONTENT_SECTION_ALIAS,
},
],
Expand Down
3 changes: 2 additions & 1 deletion src/Umbraco.Web.UI.Client/src/packages/user/section/sidebar-app/manifests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { UMB_USER_MANAGEMENT_SECTION_ALIAS } from '../constants.js';
import { UMB_USER_MANAGEMENT_MENU_ALIAS } from '../menu/index.js';
import { UMB_SECTION_ALIAS_CONDITION_ALIAS } from '@umbraco-cms/backoffice/section';

export const manifests: Array<UmbExtensionManifest> = [
{
Expand All @@ -14,7 +15,7 @@ export const manifests: Array<UmbExtensionManifest> = [
},
conditions: [
{
alias: 'Umb.Condition.SectionAlias',
alias: UMB_SECTION_ALIAS_CONDITION_ALIAS,
match: UMB_USER_MANAGEMENT_SECTION_ALIAS,
},
],
Expand Down
Loading