Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses styling inconsistencies for the uui-input component when used as a filter input across multiple parts of the UI. The changes replace the previous "display: block;" style with "width: 100%;" to ensure the input stretches to the full width of its container.
- Updated user group collection element styling
- Updated create blueprint modal styling
- Updated collection filter field styling
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Umbraco.Web.UI.Client/src/packages/user/user-group/collection/user-group-collection.element.ts | Replaces display property with width styling for uui-input |
| src/Umbraco.Web.UI.Client/src/packages/documents/documents/entity-actions/create-blueprint/modal/create-blueprint-modal.element.ts | Replaces display property with width styling for uui-input |
| src/Umbraco.Web.UI.Client/src/packages/core/collection/components/collection-filter-field.element.ts | Replaces display property with width styling for uui-input |
Comments suppressed due to low confidence (3)
src/Umbraco.Web.UI.Client/src/packages/user/user-group/collection/user-group-collection.element.ts:42
- Replacing 'display: block' with 'width: 100%' may change the rendering behavior if the default display value of uui-input is not already block-level. Consider verifying that uui-input supports width styling without explicitly setting its display type.
width: 100%;
src/Umbraco.Web.UI.Client/src/packages/documents/documents/entity-actions/create-blueprint/modal/create-blueprint-modal.element.ts:82
- Replacing 'display: block' with 'width: 100%' may affect the layout if uui-input relies on being a block element for proper rendering. Please confirm that the new style meets the intended UI requirements.
width: 100%;
src/Umbraco.Web.UI.Client/src/packages/core/collection/components/collection-filter-field.element.ts:37
- Changing from 'display: block' to 'width: 100%' may lead to unexpected layout behavior if uui-input does not automatically render as a block-level element. It might be useful to double-check if an explicit display value is needed alongside width.
width: 100%;
iOvergaard
approved these changes
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the styling of the uui-input in various locations, mainly when used as a filtering input on collections and extensions insights:
