V16-RC: Login screen cannot load public manifests#19453
Merged
leekelleher merged 7 commits intorelease/16.0from Jun 2, 2025
Merged
V16-RC: Login screen cannot load public manifests#19453leekelleher merged 7 commits intorelease/16.0from
leekelleher merged 7 commits intorelease/16.0from
Conversation
…weights as the backoffice itself does
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issues with the login screen by updating localization configurations and ensuring proper server context registration for public manifests.
- Updates localization weights, aliases, and cultures to facilitate proper overriding of login localizations.
- Introduces the required UmbServerContext for the slim backoffice and refines error handling in extension registration.
- Adjusts server extension registrator methods to disable notifications during manifest retrieval.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Umbraco.Web.UI.Login/src/localization/manifests.ts | Updates localization aliases, names, JS imports, and culture codes to remove country codes and adjust weights. |
| src/Umbraco.Web.UI.Login/src/localization/lang/en-us.ts | Minor formatting and string adjustments for localization content. |
| src/Umbraco.Web.UI.Login/src/controllers/slim-backoffice-initializer.ts | Introduces server context and revises icon registry attachment while improving error logging. |
| src/Umbraco.Web.UI.Client/src/libs/extension-api/controller/server-extension-registrator.controller.ts | Adds disableNotifications option in manifest retrieval methods. |
leekelleher
approved these changes
Jun 2, 2025
Member
leekelleher
left a comment
There was a problem hiding this comment.
Tested out, works as expected. 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes two issues:
Changes
weightof all login localizations, so that you can overwrite them as extensions by default have weight=0