Skip to content

Comments

build(deps): bump @umbraco-ui/uui from 1.14.0-rc.3 to 1.14.0-rc.4#19452

Merged
AndyButland merged 2 commits intorelease/16.0from
v16/bugfix/uui-1140rc4
May 30, 2025
Merged

build(deps): bump @umbraco-ui/uui from 1.14.0-rc.3 to 1.14.0-rc.4#19452
AndyButland merged 2 commits intorelease/16.0from
v16/bugfix/uui-1140rc4

Conversation

@iOvergaard
Copy link
Contributor

Descriptions

Bumps the UI library to rc4, which fixes #19450

Additionally, a bump in the login screen for the latest backoffice typings and the removal of a module that was not in use.

Copilot AI review requested due to automatic review settings May 30, 2025 11:58
@iOvergaard iOvergaard changed the base branch from main to release/16.0 May 30, 2025 11:59
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bumps several UI dependencies to their latest release candidates, updates backoffice typings on the login screen, and removes an unused module. Key changes include:

  • Removing the unused vite-tsconfig-paths plugin and its dependency in the login module.
  • Bumping "@umbraco-cms/backoffice" and "@umbraco-ui/uui" (with associated CSS) to the latest release candidates.
  • Refactoring the log viewer date range selector to use specific change events instead of a global input event listener.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

File Description
src/Umbraco.Web.UI.Login/vite.config.ts Removed unused plugin and updated trailing commas for consistency.
src/Umbraco.Web.UI.Login/package.json Updated the backoffice dependency version and removed the vite-tsconfig-paths dependency.
src/Umbraco.Web.UI.Client/src/packages/log-viewer/components/log-viewer-date-range-selector.element.ts Refactored date input event handling by replacing a global input listener with dedicated change events.
src/Umbraco.Web.UI.Client/package.json Updated the UI library dependencies to the latest release candidates.
Comments suppressed due to low confidence (3)

src/Umbraco.Web.UI.Login/vite.config.ts:2

  • The removal of the 'vite-tsconfig-paths' import appears intentional; please confirm that TypeScript path resolution is adequately handled elsewhere in the configuration.
import viteTSConfigPaths from 'vite-tsconfig-paths';

src/Umbraco.Web.UI.Login/package.json:19

  • The unused dependency 'vite-tsconfig-paths' has been removed; please ensure that any necessary TS path resolution is managed through alternative means.
"vite-tsconfig-paths": "^5.1.4"

src/Umbraco.Web.UI.Client/src/packages/log-viewer/components/log-viewer-date-range-selector.element.ts:42

  • [nitpick] Ensure that the use of UUIInputEvent and the type assertion for e.target.value as string matches the expected behavior across all supported browsers and contexts.
#setStartDate(e: UUIInputEvent) {

@iOvergaard iOvergaard added the dependencies Pull requests that update a dependency file label May 30, 2025
Copy link
Contributor

@AndyButland AndyButland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be perfectly honest I couldn't see the issue before the PR (I was getting 200 results on loading the font files). But I see the same afterwards so happy to approve.

@AndyButland AndyButland enabled auto-merge (squash) May 30, 2025 12:23
@AndyButland AndyButland merged commit 08400b6 into release/16.0 May 30, 2025
27 of 28 checks passed
@AndyButland AndyButland deleted the v16/bugfix/uui-1140rc4 branch May 30, 2025 12:33
@iOvergaard
Copy link
Contributor Author

To be perfectly honest I couldn't see the issue before the PR (I was getting 200 results on loading the font files). But I see the same afterwards so happy to approve.

Thanks for looking into it. Could it be that you needed to perform a clean install of npm in Umbraco.Web.UI.Login and a clean build?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

V16-RC4: Fonts are not loading on the Login screen

2 participants