build(deps): bump @umbraco-ui/uui from 1.14.0-rc.3 to 1.14.0-rc.4#19452
build(deps): bump @umbraco-ui/uui from 1.14.0-rc.3 to 1.14.0-rc.4#19452AndyButland merged 2 commits intorelease/16.0from
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR bumps several UI dependencies to their latest release candidates, updates backoffice typings on the login screen, and removes an unused module. Key changes include:
- Removing the unused vite-tsconfig-paths plugin and its dependency in the login module.
- Bumping "@umbraco-cms/backoffice" and "@umbraco-ui/uui" (with associated CSS) to the latest release candidates.
- Refactoring the log viewer date range selector to use specific change events instead of a global input event listener.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Umbraco.Web.UI.Login/vite.config.ts | Removed unused plugin and updated trailing commas for consistency. |
| src/Umbraco.Web.UI.Login/package.json | Updated the backoffice dependency version and removed the vite-tsconfig-paths dependency. |
| src/Umbraco.Web.UI.Client/src/packages/log-viewer/components/log-viewer-date-range-selector.element.ts | Refactored date input event handling by replacing a global input listener with dedicated change events. |
| src/Umbraco.Web.UI.Client/package.json | Updated the UI library dependencies to the latest release candidates. |
Comments suppressed due to low confidence (3)
src/Umbraco.Web.UI.Login/vite.config.ts:2
- The removal of the 'vite-tsconfig-paths' import appears intentional; please confirm that TypeScript path resolution is adequately handled elsewhere in the configuration.
import viteTSConfigPaths from 'vite-tsconfig-paths';
src/Umbraco.Web.UI.Login/package.json:19
- The unused dependency 'vite-tsconfig-paths' has been removed; please ensure that any necessary TS path resolution is managed through alternative means.
"vite-tsconfig-paths": "^5.1.4"
src/Umbraco.Web.UI.Client/src/packages/log-viewer/components/log-viewer-date-range-selector.element.ts:42
- [nitpick] Ensure that the use of UUIInputEvent and the type assertion for e.target.value as string matches the expected behavior across all supported browsers and contexts.
#setStartDate(e: UUIInputEvent) {
AndyButland
left a comment
There was a problem hiding this comment.
To be perfectly honest I couldn't see the issue before the PR (I was getting 200 results on loading the font files). But I see the same afterwards so happy to approve.
Thanks for looking into it. Could it be that you needed to perform a clean install of npm in Umbraco.Web.UI.Login and a clean build? |
Descriptions
Bumps the UI library to rc4, which fixes #19450
Additionally, a bump in the login screen for the latest backoffice typings and the removal of a module that was not in use.