Ensure controller is still present#19408
Merged
nielslyngsoe merged 4 commits intorelease/16.0from May 26, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a presence check to ensure a controller hasn’t been removed before calling hostConnected.
- Updated the runtime check inside the deferred promise to also verify the controller is still in the host’s list.
- Adjusted the inline comment to reflect the new condition.
src/Umbraco.Web.UI.Client/src/libs/controller-api/controller-host.mixin.ts
Outdated
Show resolved
Hide resolved
src/Umbraco.Web.UI.Client/src/libs/controller-api/controller-host.mixin.ts
Show resolved
Hide resolved
…ost.mixin.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
iOvergaard
approved these changes
May 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure a controller is still present to avoid calling hostConnected on a controller that already have been removed again.
Its a bit of an edge case, but if the user navigates super fast, or the router resolved a route that then gets replaced within a JS cycle after then this can occur.