hotfix: correct dark theme color for variant selector#19406
Merged
AndyButland merged 1 commit intorelease/16.0from May 26, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This hotfix updates the variant selector’s hover state to use the correct theme color tokens.
- Replaces
--uui-palette-*variables with--uui-color-*tokens for surface and interactive emphasis. - Ensures hover styling aligns with both light and dark theme designs.
Comments suppressed due to low confidence (1)
src/Umbraco.Web.UI.Client/src/packages/core/workspace/components/workspace-split-view/workspace-split-view-variant-selector.element.ts:598
- Consider adding a matching :focus-visible style alongside :hover to ensure keyboard users receive equivalent visual feedback.
.switch-button:hover {
AndyButland
approved these changes
May 26, 2025
Contributor
AndyButland
left a comment
AndyButland
left a comment
There was a problem hiding this comment.
Have tested and works as expected.
AndyButland
deleted the
v16/hotfix/correct-dark-theme-color-for-variant-selector
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix the variant selector so hover uses themes colors (previously it was white in white, so not readable)