Add explicit Global Search extension point#19348
Add explicit Global Search extension point#19348madsrasmussen merged 16 commits intorelease/16.0from
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements an explicit extension point for the Global Search modal, requiring an additional registration for search providers rather than auto-registering them. Key changes include adding new global search constants, updating manifest files in several packages (media, documents, document-types, dictionary, and data-type) to include the new global search manifests, and spreading the new manifests into the existing search provider registrations.
Reviewed Changes
Copilot reviewed 44 out of 44 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Umbraco.Web.UI.Client/src/packages/media/media-types/search/global-search/constants.ts | Added a new constant for media type global search alias |
| src/Umbraco.Web.UI.Client/src/packages/media/media-types/search/constants.ts | Exporting global search constants and adding a search provider alias |
| src/Umbraco.Web.UI.Client/src/packages/media/media-types/constants.ts | Updated to export new search constants |
| src/Umbraco.Web.UI.Client/src/packages/documents/documents/search/manifests.ts | Imported and spread new global search manifests into documents search manifests |
| src/Umbraco.Web.UI.Client/src/packages/documents/documents/search/global-search/manifests.ts | Created a new manifest for document global search with conditions |
| src/Umbraco.Web.UI.Client/src/packages/documents/documents/search/global-search/constants.ts | Added a new global search constant for documents |
| src/Umbraco.Web.UI.Client/src/packages/documents/documents/search/constants.ts | Updated to export document global search constants |
| src/Umbraco.Web.UI.Client/src/packages/documents/document-types/search/manifests.ts | Imported and spread new global search manifests into document types search manifests |
| src/Umbraco.Web.UI.Client/src/packages/documents/document-types/search/global-search/manifests.ts | Created a new manifest for document type global search with conditions |
| src/Umbraco.Web.UI.Client/src/packages/documents/document-types/search/global-search/constants.ts | Added a new global search constant for document types |
| src/Umbraco.Web.UI.Client/src/packages/documents/document-types/search/constants.ts | Updated to export document type global search constants |
| src/Umbraco.Web.UI.Client/src/packages/dictionary/search/manifests.ts | Imported and spread new global search manifests into dictionary search manifests |
| src/Umbraco.Web.UI.Client/src/packages/dictionary/search/global-search/manifests.ts | Created a new manifest for dictionary global search with conditions |
| src/Umbraco.Web.UI.Client/src/packages/dictionary/search/global-search/constants.ts | Added a new global search constant for dictionaries |
| src/Umbraco.Web.UI.Client/src/packages/dictionary/search/constants.ts | Updated to export dictionary global search constants |
| src/Umbraco.Web.UI.Client/src/packages/data-type/search/manifests.ts | Imported and spread new global search manifests into data type search manifests |
| src/Umbraco.Web.UI.Client/src/packages/data-type/search/global-search/manifests.ts | Created a new manifest for data type global search with conditions |
| src/Umbraco.Web.UI.Client/src/packages/data-type/search/global-search/constants.ts | Added a new global search constant for data types |
| src/Umbraco.Web.UI.Client/src/packages/data-type/search/constants.ts | Updated to export data type global search constants |
| src/Umbraco.Web.UI.Client/src/packages/data-type/constants.ts | Updated to export new search constants |
Comments suppressed due to low confidence (1)
src/Umbraco.Web.UI.Client/src/packages/documents/documents/search/manifests.ts:23
- Ensure that existing tests are updated or new tests are added to cover the new conditional registration logic for Global Search to prevent regressions.
...globalSearchManifests,
src/Umbraco.Web.UI.Client/src/packages/documents/documents/search/global-search/manifests.ts
Show resolved
Hide resolved
nielslyngsoe
left a comment
There was a problem hiding this comment.
great, I love the seperation, so we are able to make search providers without providing them or set up extra conditions for global search
Fixes #17998
Make an explicit extension point to add to the "Global Search" modal.
We currently list all "search providers" in the "Global Search" modal. We need to conditionally render some search options in global search while still making them available in all pickers.
With this new extension point, we can use the condition system on global search registrations.
Breaking Change
Search providers will no longer automatically appear in the "Global Search" modal. An additional registration is now required to add this. Manifest: