Variant Culture aware search in Document and Media Pickers#19336
Merged
kjac merged 25 commits intov16/improvement/culture-in-search-endpointsfrom May 16, 2025
Merged
Conversation
…e-in-search-endpoints-ui
…e-in-search-endpoints-ui
…e-in-search-endpoints-ui
…mprovement/culture-in-search-endpoints-ui # Conflicts: # src/Umbraco.Web.UI.Client/src/packages/core/variant/context/variant.context.ts
nielslyngsoe
approved these changes
May 16, 2025
kjac
merged commit 4d9c6ac
into
v16/improvement/culture-in-search-endpoints
3 of 4 checks passed
kjac
added a commit
that referenced
this pull request
May 19, 2025
* Added culture parameter to search APIs and propagated it to the indexed entity search service * Variant Culture aware search in Document and Media Pickers (#19336) * generate types * enable selection of entity-item-ref elements * Update input-document.element.ts * add culture to document search args * pass culture param to search end point * get variant context in document picker * add variant context * set culture in variant context when changing app language * set variant context when swithing variant in a workspace * Update content-detail-workspace-base.ts * clean up * remove from split view manager * Update property-dataset-base-context.ts * change name to fallbackCulture * simplify * get context instead of consuming * make all methods async * implement for media * Update current-user-action.extension.ts * allow null until we reach the server * remove log --------- Co-authored-by: Niels Lyngsø <niels.lyngso@gmail.com> * remove console.log * add display culture * opt-in inheritance * set observe alias to observeAppCulture * stop inheritance if specific cultures are set * remove unused import * include culture for document and media global search * await value for get methods * include orderCulture for document collections * Update document-collection.context.ts * Update document-collection.context.ts * fix self import --------- Co-authored-by: Niels Lyngsø <niels.lyngso@gmail.com> Co-authored-by: Mads Rasmussen <madsr@hey.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review #19334 first
The PR implements the UI parts for: #19322