V16 QA added a fix for a failing language test#19311
Merged
iOvergaard merged 2 commits intorelease/16.0from May 13, 2025
Merged
V16 QA added a fix for a failing language test#19311iOvergaard merged 2 commits intorelease/16.0from
iOvergaard merged 2 commits intorelease/16.0from
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes a failing language test and updates a dependency version for improved consistency in test helpers.
- Updated the test to invoke clickLanguageCreateButton instead of clickCreateLink.
- Bumped the "@umbraco/playwright-testhelpers" dependency version from "^16.0.13" to "^16.0.15".
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/Language/Language.spec.ts | Replaced old link click method with the new language button click method to fix a failing test. |
| tests/Umbraco.Tests.AcceptanceTest/package.json | Updated the dependency version of "@umbraco/playwright-testhelpers" for consistency. |
Files not reviewed (1)
- tests/Umbraco.Tests.AcceptanceTest/package-lock.json: Language not supported
iOvergaard
approved these changes
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.