Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces the Content Workspace Icon feature by adding content type icon observables to workspace contexts and rendering an icon in all workspace headers across members, media, and documents. Key changes include:
- Adding new observable properties (contentTypeIcon) to workspace context classes.
- Updating split-view elements to observe and render icons using the new observable and the ifDefined directive.
- Modifying scaffold creation in server data sources to merge in the new icon values.
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Umbraco.Web.UI.Client/src/packages/members/member/workspace/member/member-workspace.context.ts | Adds icon observable for member content type. |
| src/Umbraco.Web.UI.Client/src/packages/members/member/workspace/member/member-workspace-split-view.element.ts | Updates split-view element to observe icon and render . |
| src/Umbraco.Web.UI.Client/src/packages/members/member/repository/detail/member-detail.server.data-source.ts | Merges member type icon into the scaffold via deep merge. |
| src/Umbraco.Web.UI.Client/src/packages/members/member-type/repository/... | Renames and re-exports member type detail data source and repository. |
| src/Umbraco.Web.UI.Client/src/packages/media/media/workspace/media-workspace.context.ts | Adds icon observable for media content type. |
| src/Umbraco.Web.UI.Client/src/packages/media/media/workspace/media-workspace-split-view.element.ts | Updates media split-view element to observe icon and render . |
| src/Umbraco.Web.UI.Client/src/packages/media/media/repository/detail/media-detail.server.data-source.ts | Merges media type icon into the scaffold. |
| src/Umbraco.Web.UI.Client/src/packages/document(s)/... | Similar updates for document workspace context, split-view, and data source to use the icon observable. |
| src/Umbraco.Web.UI.Client/src/packages/core/workspace/components/workspace-split-view/workspace-split-view.element.ts | Adds a slot for icon rendering in the workspace header. |
| src/Umbraco.Web.UI.Client/src/packages/core/repository/detail/detail-data-source.interface.ts | Updates createScaffold type to use UmbDeepPartialObject for stronger typing. |
...I.Client/src/packages/members/member/workspace/member/member-workspace-split-view.element.ts
Outdated
Show resolved
Hide resolved
...braco.Web.UI.Client/src/packages/media/media/workspace/media-workspace-split-view.element.ts
Outdated
Show resolved
Hide resolved
...I.Client/src/packages/documents/documents/workspace/document-workspace-split-view.element.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…om/umbraco/Umbraco-CMS into v16/feature/content-workspace-icon
...I.Client/src/packages/documents/documents/workspace/document-workspace-split-view.element.ts
Outdated
Show resolved
Hide resolved
This was referenced Sep 8, 2025
This was referenced Oct 20, 2025
This was referenced Oct 27, 2025
This was referenced Mar 11, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR adds the Content Type icon to all Content Workspace headers to emphasize the connection between the opened item and the workspace content.