Correct the display of pending package migrations#19276
Merged
Migaroez merged 2 commits intorelease/16.0from May 8, 2025
Merged
Correct the display of pending package migrations#19276Migaroez merged 2 commits intorelease/16.0from
Migaroez merged 2 commits intorelease/16.0from
Conversation
…igration status from key value table.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes how pending package migrations are displayed by ensuring that packages without a PackageId properly fallback to using the package name when retrieving migration status, and it updates the localization key for the migration button.
- Updated the localization key for the "Run pending package migrations" button in the UI.
- Modified the key retrieval logic in the packaging service to use the package name as a fallback when PackageId is missing.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Umbraco.Web.UI.Client/src/packages/packages/package-section/views/installed/installed-packages-section-view-item.element.ts | Updates the button label's localization term to fix the localization issue. |
| src/Umbraco.Infrastructure/Services/Implement/PackagingService.cs | Adjusts key concatenation to correctly use PackageName when PackageId is absent. |
Comments suppressed due to low confidence (2)
src/Umbraco.Infrastructure/Services/Implement/PackagingService.cs:329
- [nitpick] Consider renaming 'packageKey' to 'migrationKey' to more clearly reflect its purpose in referencing a migration status key.
var packageKey = Constants.Conventions.Migrations.KeyValuePrefix + (group.Key.PackageId ?? group.Key.PackageName);
src/Umbraco.Web.UI.Client/src/packages/packages/package-section/views/installed/installed-packages-section-view-item.element.ts:134
- Please confirm that the new localization key 'packager_packageMigrationsRun' is available in the localization resources to ensure the button displays correctly.
label=${this.localize.term('packager_packageMigrationsRun')}>
Migaroez
approved these changes
May 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Fixes #19275
Description
When a package doesn't define a package Id, it's name is used to identify it's migration status in the
umbracoKeyValuetable. But when looking for the status, we were only using the ID.This PR corrects that and also resolves a small localization issue with the "Run pending package migrations" button.