V16: Localization refinements#19258
Conversation
Due to the low weighting of the built-in localizations, they should appear at the bottom, so overwrite in the `Map()` keys.
So not to depend on the manifest name.
uses underscore (instead of hyphen) as a selectable word-boundary.
Regional localizations can be added to override the generic localizations.
Copied missing localizations over to English (UK), for fallback purposes.
There was a problem hiding this comment.
Pull Request Overview
This PR refines localization by removing Swiss-specific language files since they duplicate existing generic localizations.
- Removed Italian (Switzerland), French (Switzerland), and German (Switzerland) localization files.
- Consolidated localization by relying on generic localization files (e.g., it-it, fr-fr, de-de).
Reviewed Changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Umbraco.Web.UI.Client/src/assets/lang/it-ch.ts | File removed to de-duplicate Italian localization |
| src/Umbraco.Web.UI.Client/src/assets/lang/fr-ch.ts | File removed to de-duplicate French localization |
| src/Umbraco.Web.UI.Client/src/assets/lang/de-ch.ts | File removed to de-duplicate German localization |
Comments suppressed due to low confidence (3)
src/Umbraco.Web.UI.Client/src/assets/lang/it-ch.ts:1
- Ensure that all module references and imports to the removed Italian (Switzerland) localization file have been updated to use the generic 'it-it' localization.
File removed
src/Umbraco.Web.UI.Client/src/assets/lang/fr-ch.ts:1
- Verify that no lingering references to the removed French (Switzerland) localization exist, and that the fallback to the generic 'fr-fr' localization is functioning as expected.
File removed
src/Umbraco.Web.UI.Client/src/assets/lang/de-ch.ts:1
- Double-check that the removal of the German (Switzerland) localization file does not leave orphaned imports, and that the generic 'de-de' localization is correctly used in its place.
File removed
…er-ui-culture-options
The idea is that we don't have a regional override without having a base culture.
|
Note
|
Portuguese (generic) is left empty for now.
and uses `UMB_DEFAULT_LOCALIZATION_CULTURE` constant
Description
Fixes #19227, (points 2 and 3, see #19227 (comment)).
This PR contains additional fixes that we would like to be part of v16.0.
How to test?
Go to the User workspace (for any user), see the UI Culture dropdown, do the localization options appear correct?
With the localization changes, it will be tricky to test the generic localizations, (unless if you add a custom localization file with overrides?)
With the English (UK) and English (US) differences, try switching between those cultures and noticing the differences with words such as color/colour, (try the "Color Picker Property Editor UI" data-type configuration), or anonymized/anonymised (in the "Telemetry Data" Settings dashboard).