Workspace view navigation context - #19255
Merged
nielslyngsoe merged 61 commits intoAug 22, 2025
Merged
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
failed
Aug 22, 2025 in 42s
CodeScene PR Check
Quality Gate Failed
(1 files improve in Code Health)
Gates Failed
(2 files with Complex Method, Code Duplication)
Gates Passed
See analysis details in CodeScene
Reason for failure
| Enforce advisory code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| content-type-structure-manager.class.ts | 1 advisory rule | 8.08 → 7.84 | Suppress |
| content-detail-workspace-base.ts | 1 advisory rule | 8.18 → 8.15 | Suppress |
View Improvements
| File | Code Health Impact | Categories Improved |
|---|---|---|
| workspace-split-view.context.ts | no change | Complex Method |
| content-type-structure-manager.class.ts | 8.08 → 7.84 | Primitive Obsession |
| content-type-property-structure-helper.class.ts | 8.82 → 9.69 | Complex Conditional, Deep, Nested Complexity |
Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.
Details
🚩 Declining Code Health (highest to lowest):
- Code Duplication content-type-structure-manager.class.ts
- Complex Method content-detail-workspace-base.ts: constructor
✅ Improving Code Health:
- Primitive Obsession content-type-structure-manager.class.ts
- Complex Conditional content-type-property-structure-helper.class.ts: UmbContentTypePropertyStructureHelper.observeSimilarContainers
- Complex Method workspace-split-view.context.ts: UmbWorkspaceSplitViewContext._observeVariant
- Deep, Nested Complexity content-type-property-structure-helper.class.ts: UmbContentTypePropertyStructureHelper.observeContainers
Annotations
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
constructor already has high cyclomatic complexity, and now it increases in Lines of Code from 154 to 160. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Complex Method
UmbWorkspaceSplitViewContext._observeVariant is no longer above the threshold for cyclomatic complexity. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Code Duplication
introduced similar code in: UmbContentTypeStructureManager.propertyStructuresOf,UmbContentTypeStructureManager.propertyStructuresOfGroupIds. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Primitive Obsession
The ratio of primitive types in function arguments decreases from 34.33% to 33.33%, threshold = 30.0%. The functions in this file have too many primitive types (e.g. int, double, float) in their function argument lists. Using many primitive types lead to the code smell Primitive Obsession. Avoid adding more primitive arguments.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Complex Conditional
UmbContentTypePropertyStructureHelper.observeSimilarContainers no longer has a complex conditional. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Deep, Nested Complexity
UmbContentTypePropertyStructureHelper.observeContainers is no longer above the threshold for nested complexity depth
Loading