Restored interface methods on obsolete IBackgroundTaskQueue#19223
Merged
kjac merged 2 commits intorelease/15.4.1from May 5, 2025
Merged
Restored interface methods on obsolete IBackgroundTaskQueue#19223kjac merged 2 commits intorelease/15.4.1from
kjac merged 2 commits intorelease/15.4.1from
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR restores the interface methods on the obsolete IBackgroundTaskQueue to maintain backward compatibility with the earlier interface definition.
- Added QueueBackgroundWorkItem and DequeueAsync methods with appropriate documentation.
- Ensures the obsolete interface continues to support legacy method signatures.
src/Umbraco.Infrastructure/HostedServices/IBackgroundTaskQueue.cs
Outdated
Show resolved
Hide resolved
AndyButland
changed the title
kjac
added
release/15.4.1
status/regression
AndyButland
added a commit
that referenced
this pull request
May 5, 2025
* Restore interface methods on obsolete IBackgroundTaskQueue. * Fixed typos in comment.
This was referenced Sep 28, 2025
This was referenced Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Resolves umbraco/Umbraco.Forms.Issues#1393
Description
This PR addresses the inadvertent breaking change introduced in 15.4 (see discussion in comment on linked issue).
Although this didn't get picked up by the usual static package validation checks, it wasn't sufficient to inherit from the newly introduced interface in the core project and expect the methods defined on the obsolete one to be found. Rather we need to keep the methods on the obsoleted interface too.
Testing
I've verified the following using a standalone install of the CMS with Forms, comparing before and after using the packages generated from the build pipeline for this PR.
Install CMS 15.4 and Forms 15.1.1 and after submitting a form a missing method exception will be thrown.
With this PR in place, you should find that it no longer will be and the Form's Examine index will be populated as expected with the form submission information.
Also verify that the publish with descendants works without error (as this uses the introduced interface in core).