Remove current item from UMB_ANCESTORS_ENTITY_CONTEXT when consumed within workspace#19214
Closed
madsrasmussen wants to merge 4 commits intorelease/16.0from
Closed
Conversation
madsrasmussen
added
category/breaking
category/dx
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refines the ancestor context for workspace usage by ensuring that the current entity is excluded from the ancestors array.
- Introduces a fallback value for isNew using the nullish coalescing operator.
- Refactors the ancestor mapping logic and extracts the ancestor filtering into a separate private method.
- Filters out the current entity from the ancestors list to maintain consistency.
...o.Web.UI.Client/src/packages/core/menu/menu-variant-tree-structure-workspace-context-base.ts
Outdated
Show resolved
Hide resolved
…-entity-context-when-in-workspace
Member
Author
|
Closing this PR as it will be included in #19172 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
UMB_ANCESTORS_ENTITY_CONTEXTcontains the current entity as the last item when used within a workspace context. This is not true when accessed in the tree or a collection item.To ensure consistency in the data provided, we now only apply the actual ancestors of the current entity.