Skip to content

Reposition workspace entity actions#19199

Merged
nielslyngsoe merged 9 commits intorelease/16.0from
v16/hotfix/workspace-entity-actions-position
May 1, 2025
Merged

Reposition workspace entity actions#19199
nielslyngsoe merged 9 commits intorelease/16.0from
v16/hotfix/workspace-entity-actions-position

Conversation

@madsrasmussen
Copy link
Member

Experiment with a different location for the entity actions menu within a workspace to align with how we present it in the rest of the UI and to ensure the workspace views are always positioned to the right:

Before:
Screenshot 2025-04-30 at 08 00 38

After:
Screenshot 2025-04-30 at 08 00 18

@madsrasmussen madsrasmussen marked this pull request as ready for review April 30, 2025 07:38
Copilot AI review requested due to automatic review settings April 30, 2025 07:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR repositions the entity actions menu to align with the overall workspace UI and updates associated layout and styling.

  • Remove redundant border styling on description fields.
  • Update the workspace entity action menu to use a compact button with a new icon.
  • Reorder slot renderings in the workspace editor and body layout to reflect the new menu position.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/Umbraco.Web.UI.Client/src/packages/webhook/webhook/workspace/webhook-workspace-editor.element.ts Removed border style from the description field to adjust appearance.
src/Umbraco.Web.UI.Client/src/packages/core/workspace/components/workspace-entity-action-menu/workspace-entity-action-menu.element.ts Updated action menu button to compact style with a new icon; removed extra styling.
src/Umbraco.Web.UI.Client/src/packages/core/workspace/components/workspace-editor/workspace-editor.element.ts Reordered the rendering of views and routes for a consolidated layout.
src/Umbraco.Web.UI.Client/src/packages/core/components/body-layout/body-layout.element.ts Reordered the navigation slot and added margin styling for the action menu slot to improve layout alignment.
src/Umbraco.Web.UI.Client/src/packages/content/content-type/global-components/content-type-workspace-editor-header.element.ts Removed redundant border style from the header description for UI consistency.
Comments suppressed due to low confidence (5)

src/Umbraco.Web.UI.Client/src/packages/webhook/webhook/workspace/webhook-workspace-editor.element.ts:81

  • The removal of the '--uui-input-border-color' style may affect the visual consistency of the description input. Confirm that this change aligns with the intended UI design.
--uui-input-border-color: transparent;

src/Umbraco.Web.UI.Client/src/packages/core/components/body-layout/body-layout.element.ts:112

  • The repositioning of the navigation slot after the action-menu slot is a significant layout change; please ensure that this new order meets the overall design specifications.
<slot id="navigation-slot" name="navigation" @slotchange=${(e: Event) => {

src/Umbraco.Web.UI.Client/src/packages/content/content-type/global-components/content-type-workspace-editor-header.element.ts:138

  • As with the webhook editor, the removal of the border color style in the header may alter the intended appearance; please verify that the updated styling meets the design requirements.
--uui-input-border-color: transparent;

src/Umbraco.Web.UI.Client/src/packages/core/workspace/components/workspace-entity-action-menu/workspace-entity-action-menu.element.ts:82

  • The consolidation of styles is acceptable; however, double-check that removing specific host styling does not inadvertently affect component layout across different contexts.
static override styles = [UmbTextStyles, css``];

src/Umbraco.Web.UI.Client/src/packages/core/components/body-layout/body-layout.element.ts:208

  • The newly added margin styles for the '#action-menu-slot' should be closely reviewed to ensure they maintain proper alignment on different screen sizes and layouts.
#action-menu-slot {

@madsrasmussen madsrasmussen changed the title Workspace entity actions position Reposition workspace entity actions Apr 30, 2025
@nielslyngsoe nielslyngsoe enabled auto-merge (squash) May 1, 2025 14:07
Copy link
Member

@nielslyngsoe nielslyngsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

greeaaat

@nielslyngsoe nielslyngsoe merged commit 04a10c2 into release/16.0 May 1, 2025
23 checks passed
@nielslyngsoe nielslyngsoe deleted the v16/hotfix/workspace-entity-actions-position branch May 1, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants