Adds support for retrieval of data type references when data type is routed using a GUID#19184
Merged
AndyButland merged 4 commits intov13/devfrom May 14, 2025
Conversation
…routed using a GUID.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds the ability to resolve data type references when a GUID is used in place of the integer ID, supporting a more flexible routing mechanism for data types.
- Introduces a new route attribute for handling GUID requests.
- Adds an overload for GetReferences that accepts a Guid and converts it to an integer id for lookup.
nikolajlauridsen
approved these changes
May 14, 2025
Contributor
There was a problem hiding this comment.
Looks good, and tests good, however it didn't seem right to me to fetch the entire entity to get the ID, so I checked if we could use the IdKeyMap instead, which we can 😄 since I already had already implemented this I decided to just push it, please have a look and see if you agree.
I was gonna do it in 1 commit so it could easily be rolled back, but I forgot to amend, sorry 😅
Contributor
Author
|
Agreed, that's much better - thanks. |
This was referenced Sep 30, 2025
This was referenced Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Resolves #19182
Description
Although integer IDs are used for backoffice routes in Umbraco 13, we mostly support replacing the integer ID with it's GUID equivalent. But not for data type references as shown in the linked issue.
This PR adds that support so that these requests are resolved.
Testing