attempted fix for Save and Preview button #15360

[Navya-Sinhaa]

Prerequisites

• I have added steps to test this contribution in the description below

• Create a new content node

• Publish the node

• Save and Preview the node (Adding throttling to the request would help test this easily)

• Progress animation appears until the preview window is open

If there's an existing issue for this PR then this fixes #15360

Description

Added logic to update page.previewButtonState so the spinner is visible when the state is set to 'busy'.

Bug:

Fix:

[github-actions]

Hi there @Navya-Sinhaa, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

• It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
• The automated tests all pass (see "Checks" tab on this PR)
• The level of security for this contribution is the same or improved
• The level of performance for this contribution is the same or improved
• Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
• If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
• 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[emmagarland]

Hi @Navya-Sinhaa!

Thanks for your PR to fix #15360, where Save and preview in the backend does not show any progress indicator while saving.

One of the Core Collaborators team will review this as soon as possible - it looks like @mikecp has self-assigned this too 👍

Best wishes

Emma

[mikecp]

Hi @Navya-Sinhaa ,

Thank you for your PR and for fixing this long-lasting issue 👍
I have tested your changes and they work perfectly, so let's merge them and make the UI behave in a more coherent way 😁

I see this is your first PR to the Umbraco CMS repository, thank you so much and welcome to our list of contributors 🎉

If you have (or create) an account on the new forum (https://forum.umbraco.com/), you should soon be awarded our shiny contributor's badge!

Thanks again, and we'll be looking forward to your next PR's 😉

Cheers!

[mikecp]

@nul800sebastiaan the issue mentioned V12 and V10 as being impacted, should the fix be back-ported indeed?

[nul800sebastiaan]

I don't think so: v10 is in the security phase, so no more other updates will happen, v12 is already EOL.