Skip to content

V16: Removes all generic Created, Saved, and Deleted notifications#19119

Merged
iOvergaard merged 12 commits intov16/devfrom
v16/feature/no-generic-success-notifications
Apr 24, 2025
Merged

V16: Removes all generic Created, Saved, and Deleted notifications#19119
iOvergaard merged 12 commits intov16/devfrom
v16/feature/no-generic-success-notifications

Conversation

@iOvergaard
Copy link
Contributor

Description

The motivation behind this pull request is to put an end to the bloat of success notifications in the Backoffice. In former times, the Backoffice had a very subtle notification bar and thus could show notifications without bothering the user too much. With the new Backoffice, the notification bubble has become a lot more visible, but so have all other visual elements to tell the user that an action has succeeded or not.

This is why we think we can bluntly remove the (admittedly hardcoded) generic success notification bubbles for "Created", "Saved", and "Deleted".

The UI should reflect if the action has been completed in other ways, such as redirecting to the newly created entity automatically and/or updating the trees automatically.

Copilot AI review requested due to automatic review settings April 23, 2025 13:59
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request removes the generic success notifications for "Created", "Saved", and "Deleted" actions in the Backoffice repository to reduce UI noise in the new design.

  • Removed notification-related imports and context consumption.
  • Deleted notification invocations within the create, update, and delete flows.

@Zeegaan
Copy link
Member

Zeegaan commented Apr 23, 2025

Seems alot of the E2E tests are reliant on reading the success notifications, to ensure that the operation succeded 🙈
Maybe @nhudinh0309 can help fix these broken tests 😁
IMO, we could could as a start, just instead assert that there are no error notifications present...
Ideally, we would assert that the save button changes into a ✅ at some point, but I think that requires a lot of refactoring, and is probably better suited for another PR

@iOvergaard iOvergaard merged commit b48d989 into v16/dev Apr 24, 2025
10 of 11 checks passed
@iOvergaard iOvergaard deleted the v16/feature/no-generic-success-notifications branch April 24, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments