Skip to content

Fix breaking changes

a77bea2
Select commit
Loading
Failed to load commit list.
Merged

Added custom RichTextRegexValidator to validate markup instead of JSON #19045

Fix breaking changes
a77bea2
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (v13/dev) failed May 5, 2025 in 42s

CodeScene PR Check

Quality Gate Failed

Gates Failed
Enforce advisory code health rules (2 files with Large Method, Code Duplication)

Gates Passed
3 Quality Gates Passed

See analysis details in CodeScene

Reason for failure
Enforce advisory code health rules Violations Code Health Impact
RichTextPropertyEditor.cs 1 advisory rule 8.82 → 8.55 Suppress
UmbracoBuilder.CoreServices.cs 1 advisory rule 8.94 → 8.93 Suppress

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

Details

🚩 Declining Code Health (highest to lowest):

  • Code Duplication RichTextPropertyEditor.cs
  • Large Method UmbracoBuilder.CoreServices.cs: AddCoreInitialServices

Annotations

Check warning on line 243 in src/Umbraco.Infrastructure/DependencyInjection/UmbracoBuilder.CoreServices.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/dev)

❌ Getting worse: Large Method

AddCoreInitialServices increases from 107 to 108 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.

Check warning on line 223 in src/Umbraco.Infrastructure/PropertyEditors/RichTextPropertyEditor.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/dev)

❌ Getting worse: Code Duplication

introduced similar code in: RichTextPropertyValueEditor,RichTextPropertyValueEditor. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.