Repository navigation
Content Type inheritance - #19034
Content Type inheritance#19034
Conversation
There was a problem hiding this comment.
Copilot reviewed 25 out of 25 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (4)
src/Umbraco.Web.UI.Client/src/packages/documents/document-types/entity-actions/create/manifests.ts:13
- Ensure that the newly added entity type 'UMB_DOCUMENT_TYPE_ENTITY_TYPE' is consistently referenced throughout the application and that its naming reflects its intended purpose.
forEntityTypes: [
src/Umbraco.Web.UI.Client/src/packages/core/workspace/entity-detail/entity-detail-workspace-base.ts:195
- Review the nullability of the 'asObservable' property to ensure that the observable is being correctly utilized when available.
(response as UmbRepositoryResponseWithAsObservable<DetailModelType>).asObservable?.(),
src/Umbraco.Web.UI.Client/src/packages/content/content-type/structure/content-type-structure-manager.class.ts:345
- [nitpick] Double-check that casting the update payload to 'Partial' does not mask underlying type mismatches; consider addressing the root cause of the TypeScript complaints if possible.
this.#contentTypes.updateOne(toContentTypeUnique, { containers } as Partial<T>);
src/Umbraco.Web.UI.Client/src/packages/content/content-type/workspace/views/design/content-type-design-editor-property.element.ts:264
- Ensure that the parsed value from 'e.target.value' is a valid number; consider handling NaN cases explicitly to avoid unintended sortOrder values.
#onPropertyOrderChanged = (e: UUIInputEvent) => this.#partialUpdate({ sortOrder: parseInt(e.target.value as string) ?? 0 } as UmbPropertyTypeModel);
….com/umbraco/Umbraco-CMS into v16/feature/content-type-inheritance
|
This pull request has been mentioned on Umbraco community forum. There might be relevant details there: https://forum.umbraco.com/t/did-document-type-inheritance-go-away-in-v14-v15/3143/8 |
Fixes #16510
Content Type Inheritance.