V16: Split media handling from UmbDropzoneManager#19031
Merged
iOvergaard merged 13 commits intov16/devfrom Apr 15, 2025
Merged
Conversation
src/Umbraco.Web.UI.Client/src/packages/media/media/dropzone/media-dropzone.manager.ts
Outdated
Show resolved
Hide resolved
…dia-dropzone.manager.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
iOvergaard
reviewed
Apr 15, 2025
src/Umbraco.Web.UI.Client/src/packages/media/media/dropzone/dropzone-media.element.ts
Show resolved
Hide resolved
iOvergaard
approved these changes
Apr 15, 2025
Contributor
iOvergaard
left a comment
iOvergaard
left a comment
There was a problem hiding this comment.
Tested, and it seems to work with the inheritance. It's a bit odd, I agree, but it should be alright with the proposed solution.
iOvergaard
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR separates media handling from the UmbDropzoneManager to resolve a circular dependency.
The PR introduces an UmbMediaDropzoneManager that manages all aspects of media type checking and media item and folder creation. The UmbDropzoneManager is now limited to creating temporary files only.
Unfortunately, the PR affects a couple of features that we initially promised to remove in version 17, but we had to address this now instead.
Effects of this PR:
<umb-dropzone-media>element, everything still functions as before.<umb-input-dropzone>element, everything still functions as before.UmbDropzoneManagerwill now only handle temporary files. Please use theUmbMediaDropzoneManagerfor additional media file creation.@umbraco-cms/backoffice/dropzonespace, whereas it was possible to import from "media" in V15.