Skip to content

Fix for block grid styling regression issue #15973#19014

Merged
AndyButland merged 2 commits intoumbraco:v13/devfrom
Lili-Rossiter:temp-15973
May 13, 2025
Merged

Fix for block grid styling regression issue #15973#19014
AndyButland merged 2 commits intoumbraco:v13/devfrom
Lili-Rossiter:temp-15973

Conversation

@Lili-Rossiter
Copy link
Contributor

@Lili-Rossiter Lili-Rossiter commented Apr 11, 2025

Fixes #15973

Description

Font size and font family styling updated to ensure block grid text styling matches the block list text styling.

Issue:
image

Fix:
image
image

@github-actions
Copy link

Hi there @Lili-Rossiter, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@nul800sebastiaan
Copy link
Member

Thanks @Lili-Rossiter! Could you try this out with @baseFontSize and @baseFontFamily so that it's not just hardcoding a "random" font size/family in there. I believe the variables should work.

@nul800sebastiaan
Copy link
Member

Hey @Lili-Rossiter - just checking to see if you had a chance to test out my previous suggestion?

@AndyButland
Copy link
Contributor

AndyButland commented May 12, 2025

Thanks very much for the contribution @Lili-Rossiter. I had a look at this one this morning - can confirm it resolves the styling discrepancy between the block list and grid.

image

The specific CSS that's being updated is inline in a .html files, so it's not being handled like the .less files are, and hence I don't believe we can use the variables here.

Possibly there is bigger refactor to put these inline styles into less files, but given they seem to specifically be overrides, I'd be concerned that might introduce some unexpected changes elsewhere. Given that, and that 13 will not be getting much further front-end development effort other than bug fixes, I think it'll be OK to use the hard-coded values here.

So if you are happy with that @nul800sebastiaan - I'll merge this one in for 13.9.

@AndyButland AndyButland merged commit 0597662 into umbraco:v13/dev May 13, 2025
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants