Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 112 out of 114 changed files in this pull request and generated no comments.
Files not reviewed (2)
- src/Umbraco.Web.UI.Client/package-lock.json: Language not supported
- src/Umbraco.Web.UI.Client/package.json: Language not supported
nielslyngsoe
approved these changes
Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR moves the Content, Content Type, and Property Type modules out of core and into their own package. In general, this doesn't impact packages since the import aliases remain the same:
@umbraco-cms/backoffice/content,@umbraco-cms/backoffice/content-typeand@umbraco-cms/backoffice/property-type.The reason for the move is that the content module depends on the data type module. The data type module is not part of core; therefore, we can't depend on it. Now both packages are considered external, in relation to Core, meaning they can depend on each other.
Breaking Changes:
UmbWorkspaceHasCollectionCondition
UMB_WORKSPACE_HAS_COLLECTION_CONDITION_ALIAStoUMB_WORKSPACE_HAS_CONTENT_COLLECTION_CONDITION_ALIAS.@umbraco-cms/backoffice/workspaceto@umbraco-cms/backoffice/contentUmbWorkspaceContentTypeAliasCondition
Before
import type { UmbWorkspaceContentTypeAliasConditionConfig} from '@umbraco-cms/backoffice/workspace';After
import type { UmbWorkspaceContentTypeAliasConditionConfig} from '@umbraco-cms/backoffice/content-type';UmbPropertyStructureWorkspaceContext
Before
import type { UmbPropertyStructureWorkspaceContext} from '@umbraco-cms/backoffice/workspace';import { UMB_PROPERTY_STRUCTURE_WORKSPACE_CONTEXT } from '@umbraco-cms/backoffice/workspace';After
import type { UmbPropertyStructureWorkspaceContext} from '@umbraco-cms/backoffice/content-type';import { UMB_PROPERTY_STRUCTURE_WORKSPACE_CONTEXT } from '@umbraco-cms/backoffice/content-type';