Skip to content

V16: Adds server context to store information about paths#18967

Merged
iOvergaard merged 11 commits intov16/devfrom
v16/feature/server-context
Apr 8, 2025
Merged

V16: Adds server context to store information about paths#18967
iOvergaard merged 11 commits intov16/devfrom
v16/feature/server-context

Conversation

@iOvergaard
Copy link
Contributor

@iOvergaard iOvergaard commented Apr 8, 2025 •
edited
Loading

Description

Fixes 1 circular dependency by preventing import directly from @umbraco-cms/backoffice/app.

Breaking changes

  • Introduces a new UmbServerContext that replaces UmbAppContext, so developers should use that instead to get the server URL. The API is the same.

Other changes

  • Resolves a potential import conflict of components in the image cropper

Copilot AI review requested due to automatic review settings April 8, 2025 08:38
@iOvergaard iOvergaard requested review from leekelleher and removed request for Copilot April 8, 2025 08:38
@iOvergaard iOvergaard enabled auto-merge (squash) April 8, 2025 08:38
Copilot AI reviewed Apr 8, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 24 out of 25 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • src/Umbraco.Web.UI.Client/package.json: Language not supported

@iOvergaard iOvergaard added the preview/backoffice Pull requests that can be previewed in a static version of the Backoffice label Apr 8, 2025
@github-actions
Copy link

github-actions bot commented Apr 8, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-ground-017b08103-18967.westeurope.6.azurestaticapps.net

2 similar comments
@github-actions
Copy link

github-actions bot commented Apr 8, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-ground-017b08103-18967.westeurope.6.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Apr 8, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-ground-017b08103-18967.westeurope.6.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Apr 8, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-ground-017b08103-18967.westeurope.6.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Apr 8, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-ground-017b08103-18967.westeurope.6.azurestaticapps.net

leekelleher
leekelleher approved these changes Apr 8, 2025
View reviewed changes
Copy link
Member

@leekelleher leekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out, all working as expected. 🚀

There is currently a failing acceptance test, it appears to be with the Block Grid editor. I'm unsure if it's related to this PR.

@iOvergaard iOvergaard merged commit 64e8f34 into v16/dev Apr 8, 2025
27 checks passed
@iOvergaard iOvergaard deleted the v16/feature/server-context branch April 8, 2025 11:20
@dependabot dependabot bot mentioned this pull request Sep 28, 2025
Closed
@dependabot dependabot bot mentioned this pull request Dec 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@leekelleher leekelleher leekelleher approved these changes

Assignees

No one assigned

Labels

area/frontend category/breaking preview/backoffice Pull requests that can be previewed in a static version of the Backoffice type/feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iOvergaard @leekelleher