V16: API error interceptor should return early if it will not execute#18963
Merged
iOvergaard merged 49 commits intov16/devfrom Apr 8, 2025
Merged
V16: API error interceptor should return early if it will not execute#18963iOvergaard merged 49 commits intov16/devfrom
iOvergaard merged 49 commits intov16/devfrom
Conversation
…source-controller
…notification package
…o cancel an ongoing request
Contributor
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/Umbraco.Web.UI.Client/src/packages/core/resources/api-interceptor.controller.ts:52
- Consider wrapping the JSON parsing in a try-catch block to handle potential parsing errors gracefully.
const error = await origResponse.json();
leekelleher
approved these changes
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description