Skip to content

V16: API error interceptor should return early if it will not execute#18963

Merged
iOvergaard merged 49 commits intov16/devfrom
v16/bugfix/is-notification-circular
Apr 8, 2025
Merged

V16: API error interceptor should return early if it will not execute#18963
iOvergaard merged 49 commits intov16/devfrom
v16/bugfix/is-notification-circular

Conversation

@iOvergaard
Copy link
Copy Markdown
Contributor

@iOvergaard iOvergaard commented Apr 8, 2025

Description

  • Removes export of "notifications" from "resources" to resolve leftover circular reference, which happened when moving files around
  • Returns even earlier in the error interceptor

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/Umbraco.Web.UI.Client/src/packages/core/resources/api-interceptor.controller.ts:52

  • Consider wrapping the JSON parsing in a try-catch block to handle potential parsing errors gracefully.
const error = await origResponse.json();

@iOvergaard iOvergaard changed the title V16: Resolve an unintended circular reference between notifications and resources V16: API error interceptor should return early if it will not execute Apr 8, 2025
@iOvergaard iOvergaard enabled auto-merge (squash) April 8, 2025 07:05
@iOvergaard iOvergaard merged commit fd1761d into v16/dev Apr 8, 2025
27 checks passed
@iOvergaard iOvergaard deleted the v16/bugfix/is-notification-circular branch April 8, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants