Skip to content

Enable unsaved changes warning for modals #18927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nielslyngsoe merged 1 commit into from
Apr 4, 2025
Merged

Enable unsaved changes warning for modals #18927

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions ...o.Web.UI.Client/src/packages/core/workspace/entity-detail/entity-detail-workspace-base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,13 +359,6 @@ export abstract class UmbEntityDetailWorkspaceContextBase<
return true;
}

/* TODO: temp removal of discard changes in workspace modals.
The modal closes before the discard changes dialog is resolved.*/
// TODO: I think this can go away now???
if (newUrl.includes('/modal/umb-modal-workspace/')) {
return true;
}

if (this._checkWillNavigateAway(newUrl) && this._getHasUnpersistedChanges()) {
/* Since ours modals are async while events are synchronous, we need to prevent the default behavior of the event, even if the modal hasn’t been resolved yet.
Once the modal is resolved (the user accepted to discard the changes and navigate away from the route), we will push a new history state.
Expand Down
Loading