Use StringComparison.Ordinal in hot paths#18893
Use StringComparison.Ordinal in hot paths#18893nul800sebastiaan merged 3 commits intoumbraco:contribfrom
Conversation
|
Hi there @enkelmedia, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
|
Hey @enkelmedia, good stuff, thanks! And a nice performance update! Next time, can you please be mindful of formatting? I added a lot of spaces for you in this commit 😉 617f24e Thanks again! 👍 |
|
Sorry @nul800sebastiaan 🤦🏼♂️ Thanks for fixing them, I will keep this in mind in the future :) |
Prerequisites
Description
Uses
StringComparison.Ordinalfor checks in code hot paths according to this issue:#18870