Skip to content

V15 QA Fixing the failing media acceptance tests #18881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nhudinh0309 merged 9 commits into from
Apr 8, 2025
Merged

V15 QA Fixing the failing media acceptance tests #18881

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
179321d
Fixed the function name due to test helper changes
nhudinh0309 Mar 31, 2025
5ef7327
Updated assertion steps due to UI changes
nhudinh0309 Mar 31, 2025
4d5e71e
Added more waits
nhudinh0309 Mar 31, 2025
7498a1e
Merge branch 'v15/dev' into v15/QA/fix-failing-media-tests
nhudinh0309 Mar 31, 2025
0593f1e
Bumped version
nhudinh0309 Mar 31, 2025
928341c
Increase timeout
nhudinh0309 Mar 31, 2025
719995b
Merge branch 'v15/dev' into v15/QA/fix-failing-media-tests
nhudinh0309 Apr 4, 2025
05132fa
Reverted
nhudinh0309 Apr 4, 2025
ab4aaa1
Merge branch 'v15/dev' into v15/QA/fix-failing-media-tests
andr317c Apr 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/Umbraco.Tests.AcceptanceTest/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion tests/Umbraco.Tests.AcceptanceTest/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
},
"dependencies": {
"@umbraco/json-models-builders": "^2.0.31",
"@umbraco/playwright-testhelpers": "^15.0.41",
"@umbraco/playwright-testhelpers": "^15.0.42",
"camelize": "^1.0.0",
"dotenv": "^16.3.1",
"node-fetch": "^2.6.7"
Expand Down
2 changes: 1 addition & 1 deletion ...Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithApprovedColor.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ test('can create content with the custom approved color data type', async ({umbr
const customDataTypeName = 'CustomApprovedColor';
const colorValue = 'd73737';
const colorLabel = 'Test Label';
const customDataTypeId = await umbracoApi.dataType.createDefaultApprovedColorDataTypeWithOneItem(customDataTypeName, colorLabel, colorValue);
const customDataTypeId = await umbracoApi.dataType.createApprovedColorDataTypeWithOneItem(customDataTypeName, colorLabel, colorValue);
const documentTypeId = await umbracoApi.documentType.createDocumentTypeWithPropertyEditor(documentTypeName, customDataTypeName, customDataTypeId);
await umbracoApi.document.createDefaultDocument(contentName, documentTypeId);
await umbracoUi.content.goToSection(ConstantHelper.sections.content);
Expand Down
2 changes: 1 addition & 1 deletion ....Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithUploadVectorGraphics.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ test(`can upload a file with the svg extension in the content`, async ({umbracoA
const contentData = await umbracoApi.document.getByName(contentName);
expect(contentData.values[0].alias).toEqual(AliasHelper.toAlias(dataTypeName));
expect(contentData.values[0].value.src).toContain(AliasHelper.toAlias(vectorGraphicsName));
await umbracoUi.content.doesUploadedSvgThumbnailHaveSrc(contentData.values[0].value.src);
await umbracoUi.content.doesUploadedSvgThumbnailHaveSrc(umbracoApi.baseUrl + contentData.values[0].value.src);
});

test('can remove an svg file in the content', async ({umbracoApi, umbracoUi}) => {
Expand Down
2 changes: 1 addition & 1 deletion ...ptanceTest/tests/DefaultConfig/RenderingContent/RenderingContentWithApprovedColor.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const colorValue = {label: "Test Label", value: "038c33"};
let dataTypeId = null;

test.beforeEach(async ({umbracoApi}) => {
dataTypeId = await umbracoApi.dataType.createDefaultApprovedColorDataTypeWithOneItem(customDataTypeName, colorValue.label, colorValue.value);
dataTypeId = await umbracoApi.dataType.createApprovedColorDataTypeWithOneItem(customDataTypeName, colorValue.label, colorValue.value);
});

test.afterEach(async ({umbracoApi}) => {
Expand Down
1 change: 1 addition & 0 deletions ...braco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/MediaType/MediaTypeFolder.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ test('can rename a media type folder', async ({umbracoApi, umbracoUi}) => {
await umbracoUi.mediaType.clickRootFolderCaretButton();
await umbracoUi.mediaType.clickActionsMenuForName(oldFolderName);
await umbracoUi.mediaType.clickRenameFolderButton();
await umbracoUi.waitForTimeout(500);
await umbracoUi.mediaType.enterFolderName(mediaTypeFolderName);
await umbracoUi.mediaType.clickConfirmRenameButton();

Expand Down