15.3: Hotfix: Localization culture alias case-insensitive check#18849
Merged
iOvergaard merged 1 commit intorelease/15.3.1from Mar 27, 2025
Merged
Conversation
leekelleher
added
status/regression
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements a hotfix for ensuring that localization translations are filtered in a case-insensitive manner by converting manifest culture aliases to lowercase.
- Converts the culture alias in the registry check to lowercase
- Improves the robustness of translation filtering by matching case-insensitively
Comments suppressed due to low confidence (1)
src/Umbraco.Web.UI.Client/src/packages/core/localization/registry/localization.registry.ts:71
- [nitpick] Consider ensuring that t.$code is also in lowercase (or documenting that it is always lowercased) so that the comparison remains fully case-insensitive.
diff.some((ext) => ext.meta.culture.toLowerCase() === t.$code),
This was referenced Sep 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #18801.
The localization registry filters out the translations by matching the manifest's culture alias, but it was case-sensitive. This patch makes the check case-insensitive by making the culture alias to be lowercase.