Check we have matched a preview URL by ID when exiting preview#18841
Merged
Check we have matched a preview URL by ID when exiting preview#18841
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an error when parsing a preview URL by ensuring that the ID extracted from the URL is a valid integer before using it.
- Added a guard using int.TryParse to safely parse the preview ID.
- Removed the redundant int.Parse call after the validation.
Migaroez
approved these changes
Apr 3, 2025
AndyButland
added a commit
that referenced
this pull request
Apr 3, 2025
Contributor
Author
|
Cherry-picked into |
This was referenced Sep 30, 2025
This was referenced Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
I found this issue when testing the 13.8 RC. It's not a regression introduced in 13.8 as far as I can tell, but still something we could fix up.
You can reproduce by:
With the PR in place this will no longer error.